Mir

[enhancement] Draw input event location

Bug #1323522 reported by Thomi Richards
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Wishlist
Robert Carr
Mir 0.8.0
0.6
Won't Fix
Wishlist
Robert Carr
mir (Ubuntu)
Fix Released
Wishlist
Unassigned
mir (Ubuntu RTM)
Fix Released
Wishlist
Unassigned
unity8 (Ubuntu)
Opinion
Wishlist
Gerry Boland

Bug Description

New feature request:

While running autopilot tests, it's impossible to tell where the autopilot-generated touch events are being generated. We'd like mir to draw a graphical overlay (a small blue circle perhaps) whever the touch events are being generated.

Our requirements are:

1) Must be toggleable from python.
1.1) ...Ideally wihtout having to restart unity8/mir - perhaps this could be a unity8 setting, with a way to set that from python?
2) Must draw a graphical overlay at the location of touch events generated from autopilot (to test, follow https://wiki.ubuntu.com/Touch/Testing )

Please let me know if anything doesn't make sense.

Cheers

Tags: enhancement

Related branches

lp:~mir-team/mir/touchspot-visualizer
PS Jenkins bot (community): Approve (continuous-integration)
Cemil Azizoglu (community): Approve
Alan Griffiths: Approve
Kevin DuBois: Pending requested
Daniel van Vugt: Pending requested
Diff: 983 lines (+465/-48)
26 files modified
include/server/mir/default_server_configuration.h (+3/-0)
include/server/mir/input/android/default_android_input_configuration.h (+3/-0)
include/server/mir/input/touch_visualizer.h (+58/-0)
include/test/mir_test/event_factory.h (+12/-1)
include/test/mir_test/fake_event_hub_input_configuration.h (+2/-0)
include/test/mir_test_doubles/stub_touch_visualizer.h (+43/-0)
include/test/mir_test_framework/input_testing_server_configuration.h (+1/-1)
server-ABI-sha1sums (+3/-2)
src/server/input/android/android_input_reader_policy.cpp (+7/-2)
src/server/input/android/android_input_reader_policy.h (+4/-1)
src/server/input/android/android_pointer_controller.cpp (+27/-13)
src/server/input/android/android_pointer_controller.h (+15/-9)
src/server/input/android/default_android_input_configuration.cpp (+3/-1)
src/server/input/default_configuration.cpp (+18/-0)
tests/acceptance-tests/CMakeLists.txt (+1/-0)
tests/acceptance-tests/test_client_input.cpp (+2/-2)
tests/acceptance-tests/test_server_shutdown.cpp (+2/-1)
tests/acceptance-tests/test_touchspot_visualization.cpp (+222/-0)
tests/integration-tests/input/android/test_android_cursor_listener.cpp (+3/-0)
tests/integration-tests/input/android/test_android_input_manager.cpp (+5/-1)
tests/mir_test_doubles/event_factory.cpp (+13/-5)
tests/mir_test_doubles/fake_event_hub.cpp (+8/-5)
tests/mir_test_doubles/fake_event_hub_input_configuration.cpp (+2/-1)
tests/mir_test_framework/input_testing_server_options.cpp (+2/-1)
tests/unit-tests/input/android/test_android_input_reader_policy.cpp (+3/-1)
tests/unit-tests/input/android/test_android_pointer_controller.cpp (+3/-1)
lp:~mir-team/mir/touchspot-renderable
PS Jenkins bot (community): Approve (continuous-integration)
Daniel van Vugt: Needs Fixing
Andreas Pokorny (community): Approve
Alberto Aguirre (community): Approve
Kevin DuBois (community): Approve
Cemil Azizoglu (community): Approve
Diff: 3585 lines (+2202/-95)
77 files modified
debian/control (+2/-2)
debian/libmirplatform3.install (+1/-1)
include/platform/mir/graphics/platform.h (+3/-0)
include/platform/mir/options/configuration.h (+1/-0)
include/server/mir/default_server_configuration.h (+5/-2)
include/server/mir/input/cursor_listener.h (+2/-2)
include/server/mir/input/touch_visualizer.h (+6/-2)
platform-ABI-sha1sums (+2/-2)
playground/demo-shell/demo_compositor.cpp (+6/-1)
playground/demo-shell/demo_renderer.cpp (+8/-3)
playground/demo-shell/demo_renderer.h (+7/-1)
server-ABI-sha1sums (+5/-4)
src/include/platform/mir/graphics/buffer_writer.h (+44/-0)
src/include/platform/mir/graphics/native_platform.h (+3/-0)
src/include/server/mir/compositor/scene_element.h (+4/-0)
src/include/server/mir/input/scene.h (+23/-8)
src/include/server/mir/scene/legacy_scene_change_notification.h (+2/-0)
src/include/server/mir/scene/observer.h (+4/-0)
src/platform/CMakeLists.txt (+1/-1)
src/platform/graphics/android/CMakeLists.txt (+1/-0)
src/platform/graphics/android/android_buffer_writer.cpp (+70/-0)
src/platform/graphics/android/android_buffer_writer.h (+50/-0)
src/platform/graphics/android/android_display.cpp (+1/-1)
src/platform/graphics/android/android_platform.cpp (+6/-0)
src/platform/graphics/android/android_platform.h (+1/-0)
src/platform/graphics/mesa/CMakeLists.txt (+1/-0)
src/platform/graphics/mesa/buffer_allocator.cpp (+1/-1)
src/platform/graphics/mesa/buffer_writer.cpp (+40/-0)
src/platform/graphics/mesa/buffer_writer.h (+43/-0)
src/platform/graphics/mesa/native_platform.cpp (+5/-0)
src/platform/graphics/mesa/native_platform.h (+1/-0)
src/platform/graphics/mesa/platform.cpp (+6/-0)
src/platform/graphics/mesa/platform.h (+1/-0)
src/platform/graphics/mesa/shm_buffer.cpp (+13/-0)
src/platform/graphics/mesa/shm_buffer.h (+2/-0)
src/platform/options/default_configuration.cpp (+3/-1)
src/platform/symbols.map (+2/-1)
src/server/graphics/default_configuration.cpp (+10/-0)
src/server/graphics/nested/nested_platform.cpp (+5/-0)
src/server/graphics/nested/nested_platform.h (+1/-0)
src/server/input/CMakeLists.txt (+1/-0)
src/server/input/android/android_input_registrar.cpp (+4/-0)
src/server/input/android/android_input_registrar.h (+1/-0)
src/server/input/android/android_input_target_enumerator.cpp (+4/-4)
src/server/input/android/android_input_target_enumerator.h (+3/-3)
src/server/input/android/input_sender.cpp (+9/-5)
src/server/input/android/input_sender.h (+1/-0)
src/server/input/cursor_controller.cpp (+8/-3)
src/server/input/cursor_controller.h (+3/-3)
src/server/input/default_configuration.cpp (+16/-10)
src/server/input/touchspot_controller.cpp (+166/-0)
src/server/input/touchspot_controller.h (+77/-0)
src/server/input/touchspot_image.c (+1034/-0)
src/server/scene/basic_surface.cpp (+0/-1)
src/server/scene/default_configuration.cpp (+2/-2)
src/server/scene/legacy_scene_change_notification.cpp (+5/-0)
src/server/scene/surface_stack.cpp (+78/-0)
src/server/scene/surface_stack.h (+16/-3)
src/server/symbols.map (+4/-1)
tests/acceptance-tests/test_nested_mir.cpp (+6/-1)
tests/acceptance-tests/test_touchspot_visualization.cpp (+2/-0)
tests/include/mir_test_doubles/null_platform.h (+7/-2)
tests/include/mir_test_doubles/stub_input_scene.h (+16/-5)
tests/include/mir_test_doubles/stub_scene_element.h (+5/-0)
tests/include/mir_test_doubles/stub_touch_visualizer.h (+6/-0)
tests/integration-tests/input/android/test_android_cursor_listener.cpp (+1/-1)
tests/integration-tests/input/android/test_android_input_manager.cpp (+1/-1)
tests/integration-tests/input/test_nested_input.cpp (+1/-1)
tests/mir_test_framework/stubbed_server_configuration.cpp (+13/-0)
tests/unit-tests/frontend/test_session_mediator.cpp (+1/-0)
tests/unit-tests/graphics/mesa/test_shm_buffer.cpp (+1/-1)
tests/unit-tests/graphics/nested/test_nested_platform.cpp (+5/-0)
tests/unit-tests/input/CMakeLists.txt (+1/-0)
tests/unit-tests/input/android/test_android_input_target_enumerator.cpp (+5/-4)
tests/unit-tests/input/test_cursor_controller.cpp (+12/-11)
tests/unit-tests/input/test_touchspot_controller.cpp (+199/-0)
tests/unit-tests/scene/test_surface_stack.cpp (+96/-0)
lp:ubuntu/utopic-proposed/mir
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

It would be done in the compositor. So we could do it in Mir but Unity8 does its own compositing and would require its own implementation.

Changed in mir:
status: New → Triaged
Changed in unity8:
importance: Undecided → Wishlist
Revision history for this message
Michał Sawicz (saviq) wrote :

Hmm I wonder, this is usually implemented in screencasting software - when we have one, wouldn't it be better implemented there?

Changed in unity8:
status: New → Triaged
status: Triaged → Opinion
Revision history for this message
Michał Sawicz (saviq) wrote :

Ah well if you wanted to see it when running the test locally, that'd obviously not help...

kevin gunn (kgunn72)
Changed in mir:
assignee: nobody → Robert Carr (robertcarr)
kevin gunn (kgunn72)
Changed in unity8:
assignee: nobody → Gerry Boland (gerboland)
Revision history for this message
Gerry Boland (gerboland) wrote :

This will be a bit tricky with QML, as the built in Touch event receivers accept the events completely. This will need more investigation and probably needs a couple of days work

Daniel van Vugt (vanvugt)
Changed in mir:
status: Triaged → In Progress
milestone: none → 0.6.0
tags: added: enhancement
Daniel van Vugt (vanvugt)
Changed in mir:
milestone: 0.6.0 → 0.7.0
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir/devel at revision None, scheduled for release in mir, milestone Unknown

Changed in mir:
status: In Progress → Fix Committed
Cemil Azizoglu (cemil-azizoglu)
Changed in mir:
milestone: 0.7.0 → 0.6.0
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Fix backported to lp:mir/0.6 at revision 1832.

Changed in mir:
milestone: 0.6.0 → 0.7.0
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Still in progress. More branches yet to land to complete this feature.

Changed in mir:
status: Fix Committed → In Progress
summary: - Draw input event location
+ [enhancement] Draw input event location
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

With several thousand lines of code not landed for this yet, probably safe to say won't fix in 0.6.

Daniel van Vugt (vanvugt)
Changed in mir:
milestone: 0.7.0 → 0.8.0
Daniel van Vugt (vanvugt)
Changed in mir:
milestone: 0.8.0 → 0.9.0
Daniel van Vugt (vanvugt)
Changed in mir:
milestone: 0.9.0 → 0.8.0
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir/devel at revision None, scheduled for release in mir, milestone Unknown

Changed in mir:
status: In Progress → Fix Committed
Daniel van Vugt (vanvugt)
Changed in mir (Ubuntu):
importance: Undecided → Wishlist
status: New → Triaged
Daniel van Vugt (vanvugt)
Changed in mir:
status: Fix Committed → Fix Released
Daniel van Vugt (vanvugt)
Changed in mir (Ubuntu RTM):
importance: Undecided → Wishlist
status: New → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (5.5 KiB)

This bug was fixed in the package mir - 0.8.0+14.10.20141010-0ubuntu1

---------------
mir (0.8.0+14.10.20141010-0ubuntu1) utopic; urgency=medium

  [ Daniel van Vugt ]
  * New upstream release 0.8.0 (https://launchpad.net/mir/+milestone/0.8.0)
    - Enhancements:
      . Less sensitivity to ABI breaks - many headers unused by external
        projects are now hidden and not installed by -dev packaes. If you
        require any headers that are missing, just ask.
      . Touchspots: --enable-touchspots to servers; visually shows touch
        locations (warning: This affects performance LP: #1373692).
      . Client performance reporting: Any Mir client can now get accurate
        performance information (frame rate, render time, buffer lag etc)
        logged to stdout. Just set env MIR_CLIENT_PERF_REPORT=log
      . Further improved touch responsiveness, with less lag and smoother
        scrolling (so long as you don't enable touchspots).
      . Slightly faster builds using precompiled headers.
      . Turn hardware overlays on by default. When in use, this halves the
        CPU usage of a Mir server. Already enabled in unity-system-compositor.
      . More scripting to detect ABI breaks.
      . Improved src/ tree consistency (renamed "src/shared" to "src/common").
      . Improved fatal signal design: Changed from SIGTERM to SIGHUP delivered
        to clients on unexpected server disconnection.
      . Improved library/package design to allow concurrent installations
        of different Mir versions without conflicts.
      . Fd reception code is now common to client and server.
    - ABI summary: Servers need rebuilding, but clients do not;
      . Mirclient ABI unchanged at 8
      . Mircommon ABI bumped to 2
      . Mirplatform ABI bumped to 3
      . Mirserver ABI bumped to 26
    - API changes between Mir 0.7 and 0.8:
      . Lots of headers removed from the public SDK! We have only hidden
        headers not known to be used by any known projects. Please let us
        know if anything is missing - https://bugs.launchpad.net/mir/+filebug
      . graphics::Platform - interface changed significantly.
      . Lots of server API changes to support touchspots.
      . File descriptors now passed as type Fd instead of int32_t.
    - Bug fixes:
      . [regression] Mir deb packages with versioned names cannot be installed
        simultaneously any more (LP: #1293944)
      . A frozen client can hang the whole server (LP: #1350207)
      . QtMir FTBFS: fatal error: mir/input/input_channel.h: No such file or
        directory (LP: #1365934)
      . [regression] platform-api fails to build against Mir 0.8 (LP: #1368354)
      . Mir FTBFS with gcc 4.9.1-14 (utopic update):
        auto_unblock_thread.h:44:46: error: no matching function for call to
        ‘std::thread::thread(<brace-enclosed initializer list>)’ (LP: #1369389)
      . [regression] Compositing is jerky and stutters during touch events
        (LP: #1372850)
      . unit test fails: AndroidInputReceiverSetup.slow_raw_input_doesnt_cause_
        frameskipping (LP: #1373826)
      . intermittent hang in TestClientInput (LP: #1338612)
      . TestClientInput.scene_obscure_mo...

Read more...

Changed in mir (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (5.4 KiB)

This bug was fixed in the package mir - 0.8.0+14.10.20141005-0ubuntu1

---------------
mir (0.8.0+14.10.20141005-0ubuntu1) 14.09; urgency=medium

  [ Daniel van Vugt ]
  * New upstream release 0.8.0 (https://launchpad.net/mir/+milestone/0.8.0)
    - Enhancements:
      . Less sensitivity to ABI breaks - many headers unused by external
        projects are now hidden and not installed by -dev packaes. If you
        require any headers that are missing, just ask.
      . Touchspots: --enable-touchspots to servers; visually shows touch
        locations (warning: This affects performance LP: #1373692).
      . Client performance reporting: Any Mir client can now get accurate
        performance information (frame rate, render time, buffer lag etc)
        logged to stdout. Just set env MIR_CLIENT_PERF_REPORT=log
      . Further improved touch responsiveness, with less lag and smoother
        scrolling (so long as you don't enable touchspots).
      . Slightly faster builds using precompiled headers.
      . Turn hardware overlays on by default. When in use, this halves the
        CPU usage of a Mir server. Already enabled in unity-system-compositor.
      . More scripting to detect ABI breaks.
      . Improved src/ tree consistency (renamed "src/shared" to "src/common").
      . Improved fatal signal design: Changed from SIGTERM to SIGHUP delivered
        to clients on unexpected server disconnection.
      . Improved library/package design to allow concurrent installations
        of different Mir versions without conflicts.
      . Fd reception code is now common to client and server.
    - ABI summary: Servers need rebuilding, but clients do not;
      . Mirclient ABI unchanged at 8
      . Mircommon ABI bumped to 2
      . Mirplatform ABI bumped to 3
      . Mirserver ABI bumped to 26
    - API changes between Mir 0.7 and 0.8:
      . Lots of headers removed from the public SDK! We have only hidden
        headers not known to be used by any known projects. Please let us
        know if anything is missing - https://bugs.launchpad.net/mir/+filebug
      . graphics::Platform - interface changed significantly.
      . Lots of server API changes to support touchspots.
      . File descriptors now passed as type Fd instead of int32_t.
    - Bug fixes:
      . [regression] Mir deb packages with versioned names cannot be installed
        simultaneously any more (LP: #1293944)
      . A frozen client can hang the whole server (LP: #1350207)
      . QtMir FTBFS: fatal error: mir/input/input_channel.h: No such file or
        directory (LP: #1365934)
      . [regression] platform-api fails to build against Mir 0.8 (LP: #1368354)
      . Mir FTBFS with gcc 4.9.1-14 (utopic update):
        auto_unblock_thread.h:44:46: error: no matching function for call to
        ‘std::thread::thread(<brace-enclosed initializer list>)’ (LP: #1369389)
      . [regression] Compositing is jerky and stutters during touch events
        (LP: #1372850)
      . unit test fails: AndroidInputReceiverSetup.slow_raw_input_doesnt_cause_
        frameskipping (LP: #1373826)
      . intermittent hang in TestClientInput (LP: #1338612)
      . TestClientInput.scene_obscure_mot...

Read more...

Changed in mir (Ubuntu RTM):
status: Triaged → Fix Released
Michał Sawicz (saviq)
affects: unity8 → unity8 (Ubuntu)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.