Firmware Test Suite

fwts: syntax check should disassemble/reassemble DSDT and SSDTs together

Bug #1317390 reported by Colin Ian King
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Firmware Test Suite
Fix Released
Medium
Colin Ian King
Firmware Test Suite 14.08.00

Bug Description

iASL needs to be able to resolve external control methods to get the assembly correct:

    /*
     * iASL Warning: There were 3 external control methods found during
     * disassembly, but additional ACPI tables to resolve these externals
     * were not specified. This resulting disassembler output file may not
     * compile because the disassembler did not know how many arguments
     * to assign to these methods. To specify the tables needed to resolve
     * external control method references, the -e option can be used to
     * specify the filenames. Example iASL invocations:
     * iasl -e ssdt1.aml ssdt2.aml ssdt3.aml -d dsdt.aml
     * iasl -e dsdt.aml ssdt2.aml -d ssdt1.aml
     * iasl -e ssdt*.aml -d dsdt.aml
     */

We need to fix this in the syntaxcheck test as currently it does not do this.

Colin Ian King (colin-king)
Changed in fwts:
importance: Undecided → Medium
assignee: nobody → Colin King (colin-king)
status: New → In Progress
Revision history for this message
Colin Ian King (colin-king) wrote :

Fix sent to fwts-devel mailing list https://lists.ubuntu.com/archives/fwts-devel/2014-May/004862.html

Revision history for this message
Colin Ian King (colin-king) wrote :

This patch has been waiting for nearly 2 months to be applied. Can it get some attention please?

Revision history for this message
Yang Kun (YK) (dayangkuncn) wrote :

Hi Colin, sorry for the late response, I got an error while applying these two patches:

git am *.patch
Applying: lib + tests: re-work iASL backand and API to handle externals (LP: #1317390)
error: patch failed: src/acpi/syntaxcheck/syntaxcheck.c:28
error: src/acpi/syntaxcheck/syntaxcheck.c: patch does not apply
error: patch failed: src/acpica/source/compiler/fwts_iasl_interface.h:20
error: src/acpica/source/compiler/fwts_iasl_interface.h: patch does not apply
error: patch failed: src/lib/include/fwts_iasl.h:22
error: src/lib/include/fwts_iasl.h: patch does not apply
error: patch failed: src/lib/src/fwts_iasl.c:237
error: src/lib/src/fwts_iasl.c: patch does not apply
Patch failed at 0001 lib + tests: re-work iASL backand and API to handle externals (LP: #1317390)
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".

I guess it's because the other patches we committed recently. could you please help to regenerate these two patches with the current fwts git repo ?

thanks

Revision history for this message
Colin Ian King (colin-king) wrote :

I've re-sent the patch, it applies cleanly now to today's fwts repo tip:

https://lists.ubuntu.com/archives/fwts-devel/2014-July/005077.html

Revision history for this message
Yang Kun (YK) (dayangkuncn) wrote :

patch committed

Changed in fwts:
milestone: none → 14.08.00
status: In Progress → Fix Committed
Yang Kun (YK) (dayangkuncn)
Changed in fwts:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.