bucketing of recoverable problems is done poorly

Bug #1316763 reported by Brian Murray
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Daisy
Triaged
Medium
Unassigned
apport (Ubuntu)
Fix Released
Medium
Brian Murray
Trusty
Triaged
Medium
Unassigned

Bug Description

https://errors.ubuntu.com/problem/f12769647a05d62c6397356f9c1508769f2910d9

We have recoverable problems about openshot, gimp, and nautilus all with the same DuplicateSignature.

GMenuModelItemsChangedInvalidIndex

That seems wrong.

Related branches

Revision history for this message
Brian Murray (brian-murray) wrote :

Well, it might actually be an issue with apport and its recoverable_problem file.

Revision history for this message
Brian Murray (brian-murray) wrote :

I'd think that a combination of the package name and the duplicate signature would work e.g. gimp:GMenuModeItemsChangedInvalidIndex.

Revision history for this message
Brian Murray (brian-murray) wrote :

This is an issue with apport's recoverable_problem code. While Ted suggests that viewing the problems across applications would be useful, the way the bucket page is currently designed it is best for the crashes to be about one package. Subsequently, I think apport should create the crashes with a DuplicateSignature that references the pakage name. Then we can make a view that removes this information and collects similar problems.

Revision history for this message
Brian Murray (brian-murray) wrote :

There should also be a cleanup script run against the cassandra database to update the duplicate signatures with the package names.

Changed in apport (Ubuntu):
status: New → In Progress
assignee: nobody → Brian Murray (brian-murray)
importance: Undecided → Medium
Changed in daisy:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Martin Pitt (pitti) wrote :

trunk r2803, thanks Brian!

Changed in apport (Ubuntu):
status: In Progress → Fix Committed
Changed in apport (Ubuntu Trusty):
status: New → Triaged
importance: Undecided → Medium
milestone: none → trusty-updates
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apport - 2.14.3-0ubuntu1

---------------
apport (2.14.3-0ubuntu1) utopic; urgency=medium

  * New upstream bug fix release:
    - Add kernel package version to the various kernel-related hooks. Thanks
      Brian Murray. (LP: #1316845)
    - Use package name in duplicate signature for recoverable problems. Thanks
      Brian Murray. (LP: #1316763)
    - Have whoopsie-upload-all upload recoverable problems. Thanks Brian
      Murray. (LP: #1319099)
 -- Martin Pitt <email address hidden> Fri, 30 May 2014 15:35:53 +0200

Changed in apport (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote :

The fix for this is actually did not work as Package is not defined as we have not run add_package_info() before we try and create the duplicate signature.

Changed in apport (Ubuntu):
status: Fix Released → Triaged
Revision history for this message
Brian Murray (brian-murray) wrote :

Discussing this with pitti we decided to switch to using ExecutablePath and the DuplicateSignature to create a more specific DuplicateSignature.

Changed in apport (Ubuntu):
status: Triaged → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apport - 2.17.2-0ubuntu1

---------------
apport (2.17.2-0ubuntu1) vivid; urgency=medium

  * New upstream bug fix release:
    - SECURITY UPDATE: Disable crash forwarding to containers. The previous
      fix in 2.17.1 was not sufficient against all attack scenarios. By
      binding to specially crafted sockes, a normal user program could forge
      arbitrary entries in /proc/net/unix. We cannot currently rely on a
      kernel-side solution for this; this feature will be re-enabled once it
      gets re-done to be secure. (LP: #1444518)
    - apport-kde: Fix crash when showing byte array values. Thanks Jonathan
      Riddell. (LP: #1443659)
    - Really create a better duplicate signature for recoverable problems,
      using ExecutablePath. Thanks Brian Murray. (LP: #1316763)
  * Disable Launchpad crash upload for final Ubuntu 15.04.
 -- Martin Pitt <email address hidden> Thu, 16 Apr 2015 17:51:18 -0500

Changed in apport (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote :

The change in 2.17.2-0ubuntu1 is working as expected see the following crash as an example:

https://errors.ubuntu.com/bucket/?id=/usr/bin/webbrowser-app%3Aurl-dispatcher-bad-url

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.