preview combo should autoscroll to make sure its child buttons are on screen
Bug #1316660 reported by
Michał Karnicki
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| unity8 (Ubuntu) |
Fix Released
|
Medium
|
Albert Astals Cid | ||
Bug Description
I have a preview, with 3 buttons. foo, bar, and baz. Because there's more than 2, they're collapsed to "More..." and "foo".
If the preview is large enough, the buttons are located at the bottom of the screen. When I press "More...", bar and baz overflow the bottom of the screen.
Expected:
Screen automatically scrolls so I can see the active, expanded component.
Actual:
I have to manually scroll the screen to see the expanded buttons.
Solution:
Currently the button combo is a hack. Expandable components from the SDK should be used instead.
Related branches
lp:~aacid/unity8/testFor1316660
- Andrea Cimitan (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 94 lines (+43/-1)4 files modifiedqml/Dash/Previews/Preview.qml (+1/-0)
tests/mocks/Unity/fake_previewwidgetmodel.cpp (+10/-0)
tests/qmltests/Dash/Previews/tst_Preview.qml (+31/-0)
tests/qmltests/Dash/tst_GenericScopeView.qml (+1/-1)
| summary: |
- Scope preview allows buttons overflow bottom edge + Scope preview should use SDK's Expandable*s |
| Changed in unity8: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| assignee: | nobody → Andrea Cimitan (cimi) |
| tags: | added: scope-dev |
| tags: | added: rtm14 |
| Changed in unity8: | |
| status: | Triaged → In Progress |
| assignee: | Andrea Cimitan (cimi) → Albert Astals Cid (aacid) |
Revision history for this message
| Albert Astals Cid (aacid) wrote Re: Scope preview should use SDK's Expandable*s | #1 |
| Changed in unity8: | |
| status: | In Progress → Triaged |
Revision history for this message
| Michał Sawicz (saviq) wrote | #2 |
| Changed in unity8: | |
| importance: | High → Medium |
| tags: | removed: rtm14 |
| summary: |
- Scope preview should use SDK's Expandable*s + preview combo should autoscroll to make sure its child buttons are on + screen |
| Changed in unity8 (Ubuntu): | |
| assignee: | nobody → Albert Astals Cid (aacid) |
| importance: | Undecided → Medium |
| status: | New → Triaged |
| no longer affects: | unity8 |
| Changed in unity8 (Ubuntu): | |
| status: | Triaged → In Progress |
Revision history for this message
| Albert Astals Cid (aacid) wrote | #3 |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #4 |
| Changed in unity8 (Ubuntu): | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
Saviq, i don't think the branch you linked has anything to do with this bug, the bug is about previews with more than 2 buttons (aka PreviewActions.qml using a PreviewActionCo