The client process is identified when the socket connects, not when the client connects to Mir
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Medium
|
Alan Griffiths | ||
mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
In ProtobufConnect
We also pass this information to ProtobufIpcFact
This is all fine when a client is connecting via filesystem endpoint - as the client pid remains the same throughout.
However, when the socket connection is created by Connector:
The credentials used for authorisation shouldn't be passed to make_ipc_server() - instead there should be a way to retrieve the process information when the client connects to Mir.
Related branches
- PS Jenkins bot (community): Approve (continuous-integration)
- Kevin DuBois (community): Approve
- Alexandros Frantzis (community): Approve
-
Diff: 242 lines (+94/-24)6 files modifiedinclude/server/mir/frontend/session_credentials.h (+0/-3)
src/server/frontend/published_socket_connector.cpp (+6/-0)
src/server/frontend/session_credentials.cpp (+0/-18)
src/server/frontend/socket_messenger.cpp (+54/-3)
src/server/frontend/socket_messenger.h (+6/-0)
tests/acceptance-tests/test_trust_session_helper.cpp (+28/-0)
Changed in mir: | |
assignee: | nobody → Alan Griffiths (alan-griffiths) |
status: | New → In Progress |
Changed in mir: | |
milestone: | none → 0.2.0 |
importance: | Undecided → Medium |
Changed in mir: | |
status: | Fix Committed → Fix Released |
Fix committed into lp:mir/devel at revision None, scheduled for release in mir, milestone Unknown