generated passwords aren't random enough

Bug #1309685 reported by Marc Deslauriers
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
pasaffe (Ubuntu)
Fix Released
Undecided
Unassigned
Trusty
Fix Released
Undecided
Unassigned

Bug Description

Pasaffe uses the "apg" utility to generate random passwords. Unfortunately, apg defaults to generating "pronounceable" passwords instead of random ones, which results in generated passwords not being as strong as they should, and has the numeric placed at the end of it most of the time.

This has been corrected by the following upstream commit:

http://bazaar.launchpad.net/~mdeslaur/pasaffe/trunk/revision/573

[Test Case]
1- open pasaffe
2- create new entry
3- click the button to generate random passwords

Pronounceable passwords look like this, typically with a digit at the end:

duhoifed0Ok&
cagMovtefEk4
NuzHykdieds6
chaiDrunsIf6
Biahickwyek6
GhoysbyPhit2

Truly random passwords should look more like this:

YL48AGzXIQ1g
ClSLdxI2U1RF
g3r5NYBFNFAQ
ZZ0HsVHslwNB
Xve3zaIF6uNj
vJvX9v0RIXYv

[Regression potential]

This code only touches the password generation code, if it breaks it will no longer generate random passwords.

ProblemType: Bug
DistroRelease: Ubuntu 14.04
Package: pasaffe 0.38-0ubuntu1
ProcVersionSignature: Ubuntu 3.13.0-24.46-generic 3.13.9
Uname: Linux 3.13.0-24-generic x86_64
ApportVersion: 2.14.1-0ubuntu3
Architecture: amd64
CurrentDesktop: Unity
Date: Fri Apr 18 14:27:44 2014
InstallationDate: Installed on 2013-11-26 (142 days ago)
InstallationMedia: Ubuntu 13.10 "Saucy Salamander" - Release amd64 (20131016.1)
PackageArchitecture: all
SourcePackage: pasaffe
UpgradeStatus: Upgraded to trusty on 2014-01-17 (90 days ago)

Revision history for this message
Marc Deslauriers (mdeslaur) wrote :
Changed in pasaffe (Ubuntu):
status: New → In Progress
Revision history for this message
Adam Conrad (adconrad) wrote : Please test proposed package

Hello Marc, or anyone else affected,

Accepted pasaffe into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/pasaffe/0.38-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed
Changed in pasaffe (Ubuntu Trusty):
status: In Progress → Fix Committed
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Package in -proposed works as expected.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pasaffe - 0.38-0ubuntu1.1

---------------
pasaffe (0.38-0ubuntu1.1) trusty; urgency=medium

  * Improve randomness of generated passwords (LP: #1309685):
    - debian/patches/improve_passwords.patch: change options passed to apg
      to generate truly random passwords instead of pronounceable ones.
 -- Marc Deslauriers <email address hidden> Fri, 18 Apr 2014 14:35:15 -0400

Changed in pasaffe (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Scott Kitterman (kitterman) wrote : Update Released

The verification of the Stable Release Update for pasaffe has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pasaffe - 0.38-0ubuntu1.1

---------------
pasaffe (0.38-0ubuntu1.1) trusty; urgency=medium

  * Improve randomness of generated passwords (LP: #1309685):
    - debian/patches/improve_passwords.patch: change options passed to apg
      to generate truly random passwords instead of pronounceable ones.
 -- Marc Deslauriers <email address hidden> Fri, 18 Apr 2014 14:35:15 -0400

Changed in pasaffe (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.