Awn

Offscreen Bouncing

Bug #130232 reported by Garoth on 2007-08-03

Affects		Status	Importance	Assigned to	Milestone
	Awn	Fix Released	Low	Garoth

Bug Description

Simple -- open a program that takes 5 seconds to start, then move the cursor off the dock (with autohide on). The dock moves down, but not low enough to conceal the bouncing. The result is that the tip of the icon appears repeatedly. This may be an easy fix, and I will try to take care of it in a minute...

Revision history for this message

Garoth (garoth) wrote on 2007-08-04:

Yeah, sorry, got sidetracked. I'm probably going to be able to fix this as easily as I hoped.

Miika-Petteri Matikainen (mpmatikainen) on 2007-08-04

Changed in awn:
status:	New → Confirmed

Garoth (garoth) on 2007-08-06

Changed in awn:
assignee:	nobody → garoth

Revision history for this message

Garoth (garoth) wrote on 2007-08-06:

awn-task.patch Edit (1.1 KiB, text/plain)

Ok, I've gotten around to fixing this error. However, this fix causes the bug:

https://bugs.launchpad.net/awn/+bug/130363

to worsen mildly. The way it worsens is that if you launch a double speed bouncing launcher, it will bounce offscreen just and only once. I cannot as of now explain this for the life of me. In any case, but that issue would not occur if the double speed bug removed, so I will not spend time on it in this patch. As a result, though, I will probably write another patch soon that locks the effect uniquely, so that it cannot duplicate.

Some notes though:
* This is the first patch I've ever written in C, and one of the first patches I've ever written at all. I suggest looking over it to make sure it's right... and sorry if my inexperience makes it incorrect. If the person that does this feels generous, I would love some feedback so that my future patches to projects (probably more to AWN) will be improved. (To be honest, its the first bit of C I've ever written.)
* It is a diff output of awn-task.c. Is that the standard way to submit a patch?

P.S. As a bonus fix, I removed a #define M_PI which was defined for a second time.

Changed in awn:
status:	Confirmed → In Progress

Revision history for this message

Miika-Petteri Matikainen (mpmatikainen) wrote on 2007-08-07:

Thanks for the patch. Please make patches by giving the following command in Awn root directory:
bzr di > my.patch

This offscreen bouncing problem also exist with attention effect. Could you make a patch which fixes that as well?

Revision history for this message

Garoth (garoth) wrote on 2007-08-07:

Ok, I'll do patches like that then.

Also, how do I go about causing the attention effect?... I haven't noticed the behavior that needs fixing, but maybe I haven't set it off.

Revision history for this message

Miika-Petteri Matikainen (mpmatikainen) wrote on 2007-08-07:

If an application needs attention, it will bounce and part of the icon shows up when the bar is hidden.

Revision history for this message

Garoth (garoth) wrote on 2007-08-08:

Any tips for what program to use to get it to do this at will? I can't really think of anything except Pidgin. Anyway, I'll copy-paste in the fix in the attention method, then make an 'altogether' patch with the bzr standard. Thanks for all your help, Miika.

Revision history for this message

Miika-Petteri Matikainen (mpmatikainen) wrote on 2007-08-08:

I have noticed this only with Pidgin.

Revision history for this message

Garoth (garoth) wrote on 2007-08-09:

awn-no-offscreen-bouncing.patch Edit (3.4 KiB, text/plain)

Well, here is the altogether patch. I'm not 100% sure about it, so please test! I just find it very hard to test the attention code. The rest of it seems to work. Sorry if I've buggered it, I'm still new :)

Anyway, this should...
* Stop off screen bouncing for launch
* Stop off screen bouncing for needs attention
* Remove the second #define M_PI

Revision history for this message

Miika-Petteri Matikainen (mpmatikainen) wrote on 2007-08-09:

Thanks for the patch. Merged to trunk.