Awn

Comment 2 for bug 130232

Revision history for this message
Garoth (garoth) wrote :

Ok, I've gotten around to fixing this error. However, this fix causes the bug:

https://bugs.launchpad.net/awn/+bug/130363

to worsen mildly. The way it worsens is that if you launch a double speed bouncing launcher, it will bounce offscreen just and only once. I cannot as of now explain this for the life of me. In any case, but that issue would not occur if the double speed bug removed, so I will not spend time on it in this patch. As a result, though, I will probably write another patch soon that locks the effect uniquely, so that it cannot duplicate.

Some notes though:
* This is the first patch I've ever written in C, and one of the first patches I've ever written at all. I suggest looking over it to make sure it's right... and sorry if my inexperience makes it incorrect. If the person that does this feels generous, I would love some feedback so that my future patches to projects (probably more to AWN) will be improved. (To be honest, its the first bit of C I've ever written.)
* It is a diff output of awn-task.c. Is that the standard way to submit a patch?

P.S. As a bonus fix, I removed a #define M_PI which was defined for a second time.