“start on dbus” condition may start thermald too early

Bug #1294895 reported by Chris Halse Rogers
16
This bug affects 1 person
Affects Status Importance Assigned to Milestone
thermald (Ubuntu)
Fix Released
Medium
Colin Ian King

Bug Description

I've not seen this myself, but when I was submitting fixes for thermald's upstart config here: https://github.com/01org/thermal_daemon/pull/8 the maintainer said that it caused thermald to start before some of the necessary sysfs bits were available.

Related branches

Revision history for this message
Colin Ian King (colin-king) wrote :

Perhaps we should only start thermald on run levels 2,3,4,5 in which case the necessary sysfs is already mounted. For example:

start on runlevel [2345] and started dbus

What do you reckon Chris?

Changed in thermald (Ubuntu):
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Colin Ian King (colin-king)
Changed in thermald (Ubuntu):
status: In Progress → Incomplete
Revision history for this message
Chris Halse Rogers (raof) wrote :

That seems sensible, although a bit disappointing :)

Changed in thermald (Ubuntu):
status: Incomplete → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package thermald - 1.3-6

---------------
thermald (1.3-6) unstable; urgency=medium

  * data: thermald.conf: start only at runlevels 2,3,4,5 (LP: #1294895)

 -- Colin King <email address hidden> Thu, 25 Sep 2014 11:37:00 +0100

Changed in thermald (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Srinivas Pandruvada (srinivas-pandruvada) wrote :

I am not expert in configuration files, If this is the best we can do then I will apply to my tree also.
So please suggest.

Revision history for this message
Colin Ian King (colin-king) wrote :

@Srinivas, I think it's probably the easiest safeguard for this kind of case, we've not come up with a solution that's any simpler or more elegant.

Revision history for this message
Andy Whitcroft (apw) wrote : Please test proposed package

Hello Chris, or anyone else affected,

Accepted thermald into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/thermald/1.7.0-5ubuntu4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in thermald (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed verification-needed-bionic
Revision history for this message
Colin Ian King (colin-king) wrote :

The bionic SRU test message occurred because I accidentally uploaded the package with the entire old history. This bug has already been fixed and the verification for bionic can be ignored.

Changed in thermald (Ubuntu Bionic):
status: Fix Committed → Fix Released
tags: removed: verification-needed verification-needed-bionic
no longer affects: thermald (Ubuntu Bionic)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.