Ubuntu
click package

Output of list --manifest is inconsistent with info command

Bug #1293788 reported by dobey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
click (Ubuntu)
Fix Released
Medium
Colin Watson

Bug Description

The following bit of JSON is output with "click list --manifest" for the weather app:

    {
        "_directory": "/usr/share/click/preinstalled/.click/users/@all/com.ubuntu.weather",
        "_removable": 1,
        "description": "Weather application",
        "framework": "ubuntu-sdk-13.10",
        "hooks": {
            "weather": {
                "apparmor": "apparmor.json",
                "desktop": "com.ubuntu.weather_weather.desktop",
                "urls": "com.ubuntu.weather_weather.url-dispatcher"
            }
        },
        "icon": "weather-app@30.png",
        "installed-size": "5415",
        "maintainer": "Ubuntu App Cats <email address hidden>",
        "name": "com.ubuntu.weather",
        "title": "weather",
        "version": "1.1.219",
        "x-source": {
            "vcs-bzr": "lp:ubuntu-weather-app",
            "vcs-bzr-revno": "219"
        },
        "x-test": {
            "autopilot": "ubuntu_weather_app"
        }
    }

However, "click info com.ubuntu.weather" shows the following:

{
    "description": "Weather application",
    "framework": "ubuntu-sdk-13.10",
    "hooks": {
        "weather": {
            "apparmor": "apparmor.json",
            "desktop": "com.ubuntu.weather_weather.desktop",
            "urls": "com.ubuntu.weather_weather.url-dispatcher"
        }
    },
    "icon": "weather-app@30.png",
    "installed-size": "5415",
    "maintainer": "Ubuntu App Cats <email address hidden>",
    "name": "com.ubuntu.weather",
    "title": "weather",
    "version": "1.1.219",
    "x-source": {
        "vcs-bzr": "lp:ubuntu-weather-app",
        "vcs-bzr-revno": "219"
    },
    "x-test": {
        "autopilot": "ubuntu_weather_app"
    }
}

As you can see, the _removable and _directory fields are not present in the "info" output. The same is true when using libclick to get the information, instead of the click command line tool. It should be possible to get this information for a specific click package, without having to get the info for all packages, and then parse the output to find the package one cares about.

Related branches

lp:click
Colin Watson: Approve
Ubuntu CI managed package branches: Pending requested
Diff: 485 lines (+269/-70)
11 files modified
README (+1/-0)
click/build.py (+10/-22)
click/framework.py (+138/-0)
click/install.py (+8/-28)
click/paths.py.in (+1/-0)
click/tests/helpers.py (+29/-0)
click/tests/test_build.py (+39/-5)
click/tests/test_install.py (+2/-4)
debian/changelog (+8/-0)
doc/file-format.rst (+1/-2)
doc/index.rst (+32/-9)
lp:ubuntu/trusty-proposed/click
lp:~ubuntu-managed-branches/click/click (Merged)
dobey (dobey)
summary: - _removable flag only output with list command, not info
+ Output of list --manifest is inconsistent with info command
Revision history for this message
Colin Watson (cjwatson) wrote :

Using libclick for this should include _directory, albeit not _removable. But yes, I'll fix this, thanks.

Colin Watson (cjwatson)
Changed in click (Ubuntu):
status: New → Fix Committed
importance: Undecided → Medium
assignee: nobody → Colin Watson (cjwatson)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package click - 0.4.19

---------------
click (0.4.19) trusty; urgency=medium

  [ Colin Watson ]
  * Set Click.User.ensure_db visibility back to private, since it's no
    longer used by Click.Hook. (The C ABI is unaffected.)
  * Add brief documentation on Click's multiple-database scheme, based on my
    recent mail to ubuntu-phone.
  * Fix a few potential GLib critical messages from the PackageKit plugin.
  * Make libclick-0.4-dev depend on libjson-glib-dev for
    <json-glib/json-glib.h>.
  * Add Requires.private to click-0.4.pc, so that programs built against
    libclick pick up the proper CFLAGS including glib and json-glib.
  * chroot: Allow creating 14.04 chroots.
  * Include _directory and _removable dynamic manifest keys in "click info"
    output (LP: #1293788).
  * Document -f and -s options to "click chroot" in click(1).
  * chroot: Fix code to make /finish.sh executable.
  * chroot: Make /usr/sbin/policy-rc.d executable in the chroot, as
    otherwise it has no effect.
  * chroot: Run apt-get dist-upgrade on the chroot before trying to install
    the basic build tool set. Fixes chroot creation for saucy.

  [ Benjamin Zeller ]
  * Take pkexec env vars into account when creating a chroot.

  [ Dimitri John Ledkov ]
  * Add session management to click chroot.
 -- Ubuntu daily release <email address hidden> Tue, 18 Mar 2014 14:27:53 +0000

Changed in click (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.