Mir

The server-side use of $MIR_SOCKET is confusing

Bug #1290345 reported by Alan Griffiths
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Medium
Alan Griffiths
Mir 0.21.0
mir (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

What we have now is that $MIR_SOCKET is set in DefaultServerConfiguration::the_socket_file() with the avowed intention that it is easier for children that want to know how to connect to us. However, this doesn't cover the "no-file" case - the corresponding code for that exists only in BasicServerConfiguration::launch_client().

In fact, in the "no-file" case there's no globally correct value for the socket name - a value needs to be provided for each client.

When starting up DefaultConfiguration::parse_environment() looks to see if $MIR_SOCKET is set and $MIR_SERVER_HOST_SOCKET unset. In this case it set $MIR_SERVER_HOST_SOCKET with the value of $MIR_SOCKET. It would be better if $MIR_SOCKET were used to set the default for --host-socket as then setting it in a config file would override it (as currently implemented the environment variable overrides the config file).

Related branches

lp:~alan-griffiths/mir/fix-1290345-part1
Cemil Azizoglu (community): Approve
Kevin DuBois (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Mir CI Bot: Needs Fixing (continuous-integration)
Diff: 16 lines (+0/-7)
1 file modified
src/platform/options/default_configuration.cpp (+0/-7)
lp:~alan-griffiths/mir/fix-1290345-part2
PS Jenkins bot (community): Approve (continuous-integration)
Mir CI Bot: Approve (continuous-integration)
Kevin DuBois (community): Approve
Cemil Azizoglu (community): Approve
Diff: 98 lines (+35/-7)
3 files modified
examples/server_example.cpp (+24/-2)
examples/server_example_test_client.cpp (+11/-0)
src/server/default_server_configuration.cpp (+0/-5)
kevin gunn (kgunn72)
Changed in mir:
importance: Undecided → Medium
Alan Griffiths (alan-griffiths)
Changed in mir:
assignee: nobody → Alan Griffiths (alan-griffiths)
status: New → In Progress
Daniel van Vugt (vanvugt)
Changed in mir:
milestone: none → 0.21.0
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.21.0

Changed in mir:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (3.2 KiB)

This bug was fixed in the package mir - 0.21.0+16.04.20160330-0ubuntu1

---------------
mir (0.21.0+16.04.20160330-0ubuntu1) xenial; urgency=medium

  [ Alberto Aguirre ]
  * New upstream release 0.21.0 (https://launchpad.net/mir/+milestone/0.21.0)
    - ABI summary:
      . mirclient ABI unchanged at 9
      . mirserver ABI unchanged at 38
      . mircommon ABI unchanged at 5
      . mirplatform ABI unchanged at 11
      . mirprotobuf ABI unchanged at 3
      . mirplatformgraphics ABI unchaged at 8
      . mirclientplatform ABI bumped to 5
      . mirinputplatform ABI unchanged at 5
    - Enhancements:
      . New display enumeration API
      . Added Android diagnostic tests to assist during porting to
        new devices
      . Added mir_demo_client_camera: a Video4Linux2 client
    - Bugs fixed:
      . Sometimes devices don't suspend - display turns back on
        immediately (LP: #1549701)
      . Mir crashed with exception 'failed to add sync point to command
        buffer' (LP: #1554635)
      . Mouse cursor is unusably slow in Unity 8 with a 1000Hz mouse
        (LP: #1539009)
      . Packaged mir_unit_tests binary is not suitable for general use
        (LP: #1547015)
      . [regression] Mir stops receiving input after a pause/resume
        cycle (LP: #1548989)
      . NBS (--nbuffers=0) causes software clients to crash with
        std::exception::what: Failed to mmap buffer 13, "Permission denied")
        (LP: #1550432)
      . Fullscreen clients freeze when using NBS with multiple monitors
        (LP: #1551536)
      . [ FAILED ] DisplayConfigurationTest.output_position_is_independent_of_
        orientation (LP: #1552065)
      . The server-side use of MIR_SOCKET is confusing (LP: #1290345)
      . [regression] FTBFS with -DMIR_LINK_TIME_OPTIMIZATION=on
        -Duse_debflags=on (LP: #1350343)
      . Mir On X (mesa-x11) keeps receiving mouse movement events even
        when not focused (LP: #1528110)
      . x11 platform: mouse cursor moves strange (LP: #1546324)
      . Cross compiling to wily/vivid doesn't work (LP: #1549152)
      . Rendering stutters when a new client establishes a connection
        (LP: #1549359)
      . 'mir_demo_server --test-client' crashes (SIGSEGV) when client
        dies (LP: #1555620)
      . [testfail] CI failure: TestClientInput.client_input_config_request_
        receives_all_attached_devices (LP: #1555708)
      . [regression] Mir FTBFS when MIR_ENABLE_TESTS=no (LP: #1556080)
      . Mir-on-X11 doesn't exit (until it gets an event) (LP: #1556210)
      . InputPlatformProbe.x11_platform_found_and_used_when_display_connection_
        works breaks with old input drivers present (LP: #1543049)
      . [regression] MIR_CLIENT_PERF_REPORT is missing window/surface
        names (LP: #1546933)
      . Installed binaries fail to run with mir_demo_server --test-client XXXX
        (LP: #1556160)
      . mir_demo_server --test-client [mir_demo_client_scroll|
        mir_demo_client_flicker] fails (LP: #1556205)
      . The contents of debian/mir-demos.examples are out of date and useless
        (LP: #1557446)

  [ CI Train Bot ]
  * No-change rebuild.

 -- Alberto Aguirre <alberto.aguirre@can...

Read more...

Changed in mir (Ubuntu):
status: New → Fix Released
Daniel van Vugt (vanvugt)
Changed in mir:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.