[webappcontainer] Fix url patterns override from container arg
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
webbrowser-app |
Fix Released
|
Undecided
|
Unassigned | ||
webbrowser-app (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
There are 2 ways for the webapp-container to receive a list of patterns to filter url browsing in a webapp container: through the manifest.json file that comes with a given (named) webapp, or through the command line.
At the moment, the 2 mechanisms are exclusive in the sense but not semantically equivalent. The list of url patterns in the manifest.json file is use as a mean to filter the urls that are being browsed to, but ALSO in the chromium & FF browsers to know if a webapp is to be installed/enabled when browsing in a given url.
For example, for Gmail, the hostname mail.google.com is used as a trigger to ask the user for an installation/
The issue is that for applications like google services, the authentication mechanism is common. So when launched in the container, the user will be redirected to e.g. https:/
So, the manifest.json cannot be modified to account for those, since we dont want to install a webapp from those URLs but we need a way to add extra navigation url patterns to allow google service webapps to be redirected to e.g. https:/
Related branches
- PS Jenkins bot: Approve (continuous-integration)
- Alberto Mardegan (community): Approve
- David Barth: Pending requested
- Ubuntu Phablet Team: Pending requested
-
Diff: 450 lines (+306/-46)8 files modifiedsrc/app/webcontainer/CMakeLists.txt (+1/-1)
src/app/webcontainer/WebApp.qml (+23/-5)
src/app/webcontainer/url-pattern-utils.cpp (+129/-0)
src/app/webcontainer/url-pattern-utils.h (+32/-0)
src/app/webcontainer/webapp-container.cpp (+11/-40)
tests/unittests/CMakeLists.txt (+1/-0)
tests/unittests/container-url-patterns/CMakeLists.txt (+10/-0)
tests/unittests/container-url-patterns/tst_ContainerUrlPatterns.cpp (+99/-0)
description: | updated |
Changed in webbrowser-app: | |
status: | New → Fix Released |
This bug was fixed in the package webbrowser-app - 0.23+14. 04.20140324- 0ubuntu1
--------------- 04.20140324- 0ubuntu1) trusty; urgency=low
webbrowser-app (0.23+14.
[ Alexandre Abreu ] enabled when browsing in a given url. For example, for enablement of a webapp in the browser. It /accounts. google. com or https:/ /accounts. google. ca, etc. So, /accounts. google. * etc. We provide here
* There are 2 ways for the webapp-container to receive a list of
patterns to filter url browsing in a webapp container: through the
manifest.json file that comes with a given (named) webapp, or
through the command line. At the moment, the 2 mechanisms are
exclusive in the sense that from the webapp-container's perspective
it only considers one or another when filtering navigation (the
webapp manifest one being preferred) but they are NOT semantically
equivalent. The list of url patterns in the manifest.json file is
use as a mean to filter the urls that are being browsed to, but ALSO
in the chromium & FF browsers to know if a webapp is to be
installed/
Gmail, the hostname mail.google.com is used as a trigger to ask the
user for an installation/
is also implicitely used as a filter for browser once in the
container. The issue is that for applications like google services,
the authentication mechanism is common. So when launched in the
container, the user will be redirected to e.g.
https:/
the manifest.json cannot be modified to account for those, since we
dont want to install a webapp from those URLs but we need a way to
add extra navigation url patterns to allow google service webapps to
be redirected to e.g. https:/
2 things: an way for the url patterns passed down from the command
line to be also considered in the navigation filtering,. a way to
simplify url patterns for google apps (LP: #1288982)
-- Ubuntu daily release <email address hidden> Mon, 24 Mar 2014 19:14:54 +0000