Ubuntu
qtorganizer5-eds package

Clock and calendar tests fail with static void QOrganizerEDSEngine::itemsAsyncListed(ECalComponent*, time_t, time_t, FetchRequestData*)

Bug #1282129 reported by Nicholas Skaggs
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ubuntu Calendar App
Fix Released
Undecided
Unassigned
Ubuntu Clock App
Fix Released
High
Unassigned
Ubuntu Clock App 1.8 "14.04-month-4"
Ubuntu UI Toolkit
Fix Released
Undecided
Unassigned
Ubuntu UI Toolkit february-2014
qtorganizer5-eds (Ubuntu)
Fix Released
High
Unassigned
ubuntu-ui-toolkit (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

It appears the bugfix for this bug; https://bugs.launchpad.net/ubuntu/+source/qtorganizer5-eds/+bug/1274792 causes clock to no longer work properly. Attempting to launch the app results in the app fails to start. Both the clock and calendar app logs contain things like;

static void QOrganizerEDSEngine::itemsAsyncListed(ECalComponent*, time_t, time_t, FetchRequestData*)
APPEND QOrganizerItemDetail(name=2100, key=3079, 2101=QVariant(QDateTime, QDateTime("Wed Jan 1 12:28:07 2014") ) , 2102=QVariant(QDateTime, QDateTime("Wed Jan 1 13:38:07 2014") ) )
APPEND QOrganizerItemDetail(name=0, key=2928)
static void QOrganizerEDSEngine::itemsAsyncListed(ECalComponent*, time_t, time_t, FetchRequestData*)

I'm not sure if calendar works after the fix as well, it seems like it too still suffers from the issue.

Some example runs;

http://91.189.93.70:8080/job/generic-mediumtests-trusty/1405/testReport/junit/calendar_app.tests.test_weekview/TestWeekView/test_show_next_weeks_with_mouse_/

http://91.189.93.70:8080/job/generic-mediumtests-trusty/1389

See original description

Related branches

lp:~renatofilho/qtorganizer5-eds/limit-number-of-events
Nicholas Skaggs (community): Approve
PS Jenkins bot: Approve (continuous-integration)
Ubuntu Phablet Team: Pending requested
Diff: 151 lines (+35/-18)
5 files modified
qorganizer/qorganizer-eds-engine.cpp (+15/-0)
qorganizer/qorganizer-eds-fetchrequestdata.cpp (+12/-11)
tests/unittest/CMakeLists.txt (+2/-1)
tests/unittest/collections-test.cpp (+1/-1)
tests/unittest/event-test.cpp (+5/-5)
lp:~renatofilho/ubuntu-ui-toolkit/limit-alarms-fetch
Zsombor Egri: Approve
PS Jenkins bot: Approve (continuous-integration)
Nicholas Skaggs (community): Approve
Diff: 36 lines (+14/-1)
2 files modified
modules/Ubuntu/Components/plugin/adapters/alarmsadapter_organizer.cpp (+13/-0)
tests/unit/tst_alarms/tst_alarms.cpp (+1/-1)
lp:ubuntu/trusty-proposed/qtorganizer5-eds
Nicholas Skaggs (nskaggs)
description: updated
David Planella (dpm)
Changed in qtorganizer5-eds (Ubuntu):
status: New → Triaged
importance: Undecided → High
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

apparently this is caused because the app does not specify any date interval when querying for events. This can return a unlimited number of events. For example a event that has daily recurrence will appear several/unlimited times on the query. The proper fix for that is always use a date interval when querying for events.

Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

A workaround solution for that is this branch: https://code.launchpad.net/~renatofilho/qtorganizer5-eds/limit-number-of-events/+merge/207542

this will limit the events by the current year if no date was specified on the query

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

The workaround works for calendar, but not clock as of yet. We'll decide on moving forward without both if necessary.

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

At this point, the two merges proposed by renato workaround both issues; a longer term fix will at some point be needed, with potential changes in the core apps as well.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package qtorganizer5-eds - 0.1.1+14.04.20140221-0ubuntu1

---------------
qtorganizer5-eds (0.1.1+14.04.20140221-0ubuntu1) trusty; urgency=low

  [ Renato Araujo Oliveira Filho ]
  * Limited the number of events returned when no date interval is
    specified. (LP: #1282129)
 -- Ubuntu daily release <email address hidden> Fri, 21 Feb 2014 19:27:00 +0000

Changed in qtorganizer5-eds (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 0.1.46+14.04.20140224-0ubuntu1

---------------
ubuntu-ui-toolkit (0.1.46+14.04.20140224-0ubuntu1) trusty; urgency=low

  [ Renato Araujo Oliveira Filho ]
  * [alarms] Filter only alarms of the current week. This is necessary
    because query for events without a valid date interval will return
    all events on the database, including the recurrence ones. Ex. A
    alarm that recurs every day, will be returned infinite times. (LP:
    #1282129)
 -- Ubuntu daily release <email address hidden> Mon, 24 Feb 2014 21:54:01 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Fix Released
Florian Boucault (fboucault)
Changed in ubuntu-ui-toolkit:
milestone: none → february-2014
status: New → Fix Released
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

This successfully fixed the issue for the clock app. Hence marking it fixed for the clock app project.

Changed in ubuntu-clock-app:
status: New → Fix Released
milestone: none → 1.8
importance: Undecided → High
Nicholas Skaggs (nskaggs)
Changed in ubuntu-calendar-app:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.