Ninja parallel builds fail due to missing lightdm dependency info

Bug #1268525 reported by Michał Sawicz
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity8 (Ubuntu)
Fix Released
High
Michael Terry

Bug Description

Unity8 doesn't currently build, 'cause -llightdm-qt5-2 is hardcoded in a few places.

It should use pkg-config and we need a debian/control entry.

ProblemType: Bug
DistroRelease: Ubuntu 14.04
Package: unity8 7.84+14.04.20131220-0ubuntu1
Uname: Linux 3.4.0-3-mako armv7l
ApportVersion: 2.12.7-0ubuntu6
Architecture: armhf
Date: Mon Jan 13 11:42:21 2014
InstallationDate: Installed on 2014-01-10 (3 days ago)
InstallationMedia: Ubuntu Trusty Tahr (development branch) - armhf (20140110)
ProcEnviron:
 TERM=linux
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 SHELL=/bin/bash
SourcePackage: unity8
UpgradeStatus: No upgrade log present (probably fresh install)

Related branches

Revision history for this message
Michał Sawicz (saviq) wrote :
Changed in unity8 (Ubuntu):
status: New → Confirmed
Changed in unity8:
status: New → Triaged
importance: Undecided → Critical
assignee: nobody → Michael Terry (mterry)
Revision history for this message
Michael Terry (mterry) wrote :

I can't reproduce the build problem on my mako. And the build-dep/hardcoding isn't a problem because it's all just demo code right now. We statically link our fake liblightdm right now. Once we split the greeter, these will be fixed.

Changed in unity8:
status: Triaged → Incomplete
assignee: Michael Terry (mterry) → Michał Sawicz (saviq)
Revision history for this message
Michał Sawicz (saviq) wrote :

Ah so it's just about ordering - when the build's parallel, the mock lightdm .sos can not get built before they're being used, so we're just missing some DEPENDS in CMake.

Changed in unity8:
status: Incomplete → Triaged
importance: Critical → High
Michał Sawicz (saviq)
Changed in unity8:
assignee: Michał Sawicz (saviq) → Michael Terry (mterry)
Revision history for this message
Michael Terry (mterry) wrote :

This doesn't actually affect the ubuntu build, only local ninja builds. So I'm dropping the ubuntu task.

Changed in unity8:
status: Triaged → In Progress
no longer affects: unity8 (Ubuntu)
summary: - There's no build-dep on liblightdm-qt5-*-dev and -2 is hardocoded
+ Ninja parallel builds fail due to missing lightdm dependency info
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:unity8 at revision 637, scheduled for release in unity8, milestone phone-v1-freeze

Changed in unity8:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (4.4 KiB)

This bug was fixed in the package unity8 - 7.84+14.04.20140128-0ubuntu1

---------------
unity8 (7.84+14.04.20140128-0ubuntu1) trusty; urgency=low

  [ Michal Hruby ]
  * Added unity-scope-tool, which will help when developing scopes.

  [ Michał Sawicz ]
  * Added unity-scope-tool, which will help when developing scopes.
  * Use full DashContent, not just GenericScopeView in ScopeTool.qml.
  * Bring Card and CardHeader over from new-scopes.
  * Work around bug #1268578. (LP: #1268578)
  * Drop unnecessary version dependencies.
  * Return null instead of undefined from findChild and
    findInvisibleChild.
  * Fix CardHeader and Card heights (empty Label does have non-zero
    height apparently). Also improve test robustness and reduce future
    diffs.

  [ Albert Astals ]
  * Do not assert if the item we are removing was not created yet
    (because e.g. it's not in the viewport).
  * Position correctly the pointer of the search history box .
  * Make test_filter_expand_expand less unstable in CI VMs Make sure
    header0 is the header0 we want to click On the CI VM stuff is a bit
    slower than on real hw and we were clicking in the wrong place.
  * Add TabBar to the Dash header navigation Changes this comes with: *
    DashBar at the bottom is gone * PageHeader doesn't have a Label
    anymore, it has the childItem property where you add which thing it
    has to contain * New: PageHeaderLabel mimics the old behaviour of
    PageHeader * The header of the LVWPH of GenericScopeView is now fake
    and only used for positioning. There is a single global floating
    header in DashContent (which is a PageHeader with a TabBar as
    childItem) * The GenericScopeView previewLoader and OpenEffect have
    been also moved to the DashContent so that the openEffect includes
    the floating header in the "animation" .
  * Introduce the HorizontalJournal.
  * If there are no items m_firstVisibleIndex has to be -1 .
  * Add some more documentation about tests to the CODING file.
  * Fixes to the journal cmake tests code * Output to the correct
    filename for the test * Don't output stuff from the tryXYZ targets.
  * Adapt to findChild return value changes .
  * Organic Grid for the Dash View.
  * Misc journal fixes Don't init *modelIndex to INT_MAX Makes no sense
    since we're not doing any qMin and the calling function also accepts
    any index >= 0 as valid so in some cases it may end up wanting to
    create an index that doesn't exist Don't refill if height() < 0,
    that gives bad ranges for from/to and the code gets confused .

  [ Michał Karnicki ]
  * Fix grid view column count.
  * Add test for minimum number of items in a carousel.

  [ Allan LeSage ]
  * Add stubs for indicators autopilot tests.

  [ Andrea Cimitan ]
  * Avoid input falling through notifications onto surfaces below, thus
    fixing LP: #1257312. (LP: #1257312)

  [ Leo Arias ]
  * Close the Touch devices after the tests. (LP: #1267600)
  * Added methods to scroll to other scopes on autopilot tests.
  * Added autopilot helpers for the app scope and the app preview.
    Install the fake scopes in order to use them on the tests. (LP:
    #1269114)
  * On autopilot hel...

Read more...

Changed in unity8 (Ubuntu):
status: New → Fix Released
Michał Sawicz (saviq)
Changed in unity8:
status: Fix Committed → Fix Released
Michał Sawicz (saviq)
Changed in unity8 (Ubuntu):
assignee: nobody → Michael Terry (mterry)
importance: Undecided → High
no longer affects: unity8
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.