webbrowser fails to build against Qt 5.2

Bug #1258038 reported by Timo Jyrinki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
webbrowser-app
Fix Released
Critical
Olivier Tilloy
webbrowser-app (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Build log attached.

---
/home/ubuntu/delete/build-area/webbrowser-app-0.22+14.04.20131107/src/Ubuntu/Components/Extras/Browser/webview-thumbnailer.cpp:127:7
3: error: ‘class QSGContext’ has no member named ‘createRenderer’
         m_renderer = QQuickItemPrivate::get(this)->sceneGraphContext()->createRenderer();
                                                                         ^
make[3]: *** [src/Ubuntu/Components/Extras/Browser/CMakeFiles/ubuntu-ui-extras-browser-plugin.dir/webview-thumbnailer.cpp.o] Error 1
make[3]: Leaving directory `/home/ubuntu/delete/build-area/webbrowser-app-0.22+14.04.20131107/obj-x86_64-linux-gnu'
make[2]: *** [src/Ubuntu/Components/Extras/Browser/CMakeFiles/ubuntu-ui-extras-browser-plugin.dir/all] Error 2
make[2]: *** Waiting for unfinished jobs....
---

The solution should be so that the source builds both against Qt 5.0.2 and 5.2, possibly via #ifdef:s or such.

To reproduce:
apt-add-repository ppa:canonical-qt5-edgers/qt5-beta2
apt-get update
apt-get dist-upgrade
bzr branch lp:webbrowser-app
cd webbrowser-app
bzr bd

Tags: qt5.2

Related branches

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :
Changed in webbrowser-app:
importance: High → Critical
description: updated
Revision history for this message
Olivier Tilloy (osomon) wrote :

I can reliably reproduce the build failure with Qt 5.2. Looking into fixing it.

Changed in webbrowser-app:
assignee: nobody → Olivier Tilloy (osomon)
status: New → Confirmed
Olivier Tilloy (osomon)
Changed in webbrowser-app:
status: Confirmed → In Progress
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:webbrowser-app at revision 423, scheduled for release in webbrowser-app, milestone ubuntu-13.04-month-5

Changed in webbrowser-app:
status: In Progress → Fix Committed
Changed in webbrowser-app (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webbrowser-app - 0.23+14.04.20140115.1-0ubuntu1

---------------
webbrowser-app (0.23+14.04.20140115.1-0ubuntu1) trusty; urgency=medium

  [ Olivier Tilloy ]
  * Bump version to 0.23 in preparation for the next major release.
  * Split the app into two executables: webbrowser-app and webapp-
    container.
  * Cleaner workaround for bug #1248620. Thanks Thomi for the
    suggestion!. (LP: #1248620)
  * Update the link to the list of overrides for B2G.
  * Add ignore rules for generated ninja files.
  * Use the local test server everywhere instead of writing temporary
    html pages on disk.
  * Fix FTBFS with Qt 5.2. (LP: #1258038)
  * Ensure the test server is up and responding before starting the
    tests, and use standard logging everywhere.
  * Re-execute web application in the dedicated container (compatibility
    mode for legacy webapps).

  [ Omer Akram ]
  * move the close button of the running activity to the left.

  [ Alexandre Abreu ]
  * Further separate the two webbrowser-app & webapp-container projects.
    (LP: #1246935)
  * Restrict url webapps pattern replacement depending on which part is
    being affected. (LP: #1240685)
  * Fix back forward hud actions.

  [ daker ]
  * Fix for uppercase urls. (LP: #1244329)
  * Fixed UA string for huffpost.com. (LP: #1223937)

  [ Timo Jyrinki ]
  * libqt5v8-5-private-dev will be dropped from Qt 5.2. qtdeclarate-
    private-dev 5.0.2 now depends on it until then.

  [ Adnane Belmadiaf ]
  * Change the default homepage to start.ubuntu.com. (LP: #1250995)
  * Fixed UA string for huffpost.com. (LP: #1223937)

  [ David Barth ]
  * Make sure we are redirected to the mobile version automatically, by
    presenting a mobile user-agent string on the /whole/ youtube domain
    (not just m.youtube.com). The string is also changed to the simpler
    ua string used for facebook.com. It gives the same UI, but avoids
    being seen as an Apple browser, which itself prevents rtsp/3gp
    content to be served to our browser. We (barely) support html5 video
    now.
  * Re-execute web application in the dedicated container (compatibility
    mode for legacy webapps).

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 435
 -- Ubuntu daily release <email address hidden> Wed, 15 Jan 2014 19:37:19 +0000

Changed in webbrowser-app (Ubuntu):
status: Fix Committed → Fix Released
Olivier Tilloy (osomon)
Changed in webbrowser-app:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.