Manager uses pimpl pattern when it is no needed
Bug #1251885 reported by
Manuel de la Peña
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-download-manager |
Fix Released
|
Medium
|
Manuel de la Peña | ||
ubuntu-download-manager (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The manager uses the pimpl pattern when it is a class that will not be used by any other projects and therefore is not needed.
Related branches
lp:~mandel/ubuntu-download-manager/remove-manager-pimpl
- Diego Sarmentero (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 785 lines (+215/-316)6 files modifiedlibubuntudownloadmanager/downloads/manager.cpp (+167/-270)
libubuntudownloadmanager/downloads/manager.h (+25/-5)
ubuntu-download-manager-tests/downloads/test_daemon.cpp (+9/-11)
ubuntu-download-manager-tests/downloads/test_daemon.h (+1/-1)
ubuntu-download-manager-tests/downloads/test_download_manager.cpp (+11/-27)
ubuntu-download-manager-tests/downloads/test_download_manager.h (+2/-2)
Changed in ubuntu-download-manager: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:ubuntu-download-manager at revision None, scheduled for release in ubuntu- download- manager, milestone 0.3