Change "Show Desktop" icon option label when this option is in the state where it will reverse the prior show desktop action.
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ayatana Design |
Fix Committed
|
Low
|
John Lea | ||
Unity |
Fix Released
|
Low
|
Brandon Schaefer | ||
7.2 |
Fix Released
|
Low
|
Unassigned | ||
unity (Ubuntu) |
Fix Released
|
Low
|
Brandon Schaefer | ||
Trusty |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[ Impact ]
The label on the show desktop / show windows icon in the Unity Switcher does not change even when the function of the button has changed. This can be just a little bit confusing.
[ Test Case ]
(1) Open several applications with windows.
(2) Using Alt-Tab, bring up the Switcher and keeping the Alt key depressed and using the Tab key, navigate to the leftmost icon, which should be labeled "Show Desktop". Release all keys. Only the desktop should be displayed.
(3) Again using Alt-Tab, navigate back to the leftmost icon. Its label should have changed to "Restore Windows" to indicate its changed function.
[ Regression Potential ]
About the worst that could happen is the incorrect label is applied to the icon in the Switcher.
[ Other Info ]
The Ubuntu 14.04 LTS SRU has been cherry-picked from the Ubuntu 14.04 release where it has shown to be stable.
Related branches
- Christopher Townsend: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 74 lines (+19/-1)4 files modifiedlauncher/DesktopLauncherIcon.cpp (+13/-1)
launcher/DesktopLauncherIcon.h (+2/-0)
unity-shared/PluginAdapter.cpp (+2/-0)
unity-shared/WindowManager.h (+2/-0)
- Marco Trevisan (Treviño): Approve
-
Diff: 6023 lines (+2168/-709)105 files modifiedCMakeLists.txt (+1/-0)
UnityCore/DBusIndicators.cpp (+11/-0)
UnityCore/DBusIndicators.h (+1/-0)
UnityCore/DesktopUtilities.cpp (+12/-0)
UnityCore/DesktopUtilities.h (+1/-0)
UnityCore/GLibDBusProxy.cpp (+100/-3)
UnityCore/GLibDBusProxy.h (+6/-0)
UnityCore/GLibWrapper-inl.h (+12/-0)
UnityCore/GLibWrapper.h (+1/-0)
UnityCore/GnomeSessionManager.cpp (+0/-1)
UnityCore/Indicators.h (+1/-0)
dash/FilterBasicButton.cpp (+6/-3)
dash/previews/ActionButton.cpp (+5/-2)
dash/previews/ErrorPreview.cpp (+1/-0)
dash/previews/PaymentPreview.cpp (+3/-1)
data/CMakeLists.txt (+1/-0)
data/pam/CMakeLists.txt (+1/-0)
data/pam/unity (+2/-0)
debian/changelog (+59/-0)
debian/rules (+1/-1)
debian/unity.install (+1/-0)
debian/unity.migrations (+1/-0)
decorations/DecoratedWindow.cpp (+155/-64)
decorations/DecorationsEdgeBorders.cpp (+32/-19)
decorations/DecorationsForceQuitDialog.cpp (+17/-3)
decorations/DecorationsManager.cpp (+17/-26)
decorations/DecorationsPriv.h (+12/-3)
decorations/DecorationsTitle.cpp (+1/-0)
decorations/DecorationsWidgets.cpp (+13/-1)
decorations/DecorationsWidgets.h (+5/-0)
doc/unity.1 (+35/-10)
hud/HudIconTextureSource.cpp (+0/-5)
hud/HudIconTextureSource.h (+0/-1)
launcher/ApplicationLauncherIcon.cpp (+2/-0)
launcher/DesktopLauncherIcon.cpp (+13/-1)
launcher/DesktopLauncherIcon.h (+2/-0)
launcher/Launcher.cpp (+1/-3)
launcher/LauncherIcon.cpp (+117/-104)
launcher/LauncherIcon.h (+12/-8)
launcher/MockLauncherIcon.h (+0/-5)
launcher/SwitcherView.cpp (+9/-1)
launcher/Tooltip.cpp (+5/-4)
lockscreen/BackgroundSettings.cpp (+13/-11)
lockscreen/BackgroundSettings.h (+0/-1)
lockscreen/CMakeLists.txt (+2/-0)
lockscreen/CofView.cpp (+15/-2)
lockscreen/CofView.h (+3/-1)
lockscreen/LockScreenAbstractShield.h (+14/-1)
lockscreen/LockScreenController.cpp (+54/-14)
lockscreen/LockScreenController.h (+12/-3)
lockscreen/LockScreenPanel.cpp (+31/-2)
lockscreen/LockScreenSettings.cpp (+2/-0)
lockscreen/LockScreenSettings.h (+2/-1)
lockscreen/LockScreenShield.cpp (+60/-29)
lockscreen/LockScreenShield.h (+10/-3)
lockscreen/LockScreenShieldFactory.cpp (+7/-2)
lockscreen/LockScreenShieldFactory.h (+12/-2)
lockscreen/ShutdownNotifier.cpp (+152/-0)
lockscreen/ShutdownNotifier.h (+51/-0)
lockscreen/SuspendNotifier.cpp (+153/-0)
lockscreen/SuspendNotifier.h (+51/-0)
lockscreen/UserAuthenticatorPam.cpp (+1/-2)
lockscreen/UserPromptView.cpp (+96/-17)
lockscreen/UserPromptView.h (+5/-4)
panel/PanelIndicatorEntryView.cpp (+1/-1)
panel/PanelMenuView.cpp (+83/-38)
panel/PanelMenuView.h (+1/-1)
plugins/unityshell/src/unityshell.cpp (+29/-35)
plugins/unityshell/src/unityshell.h (+2/-2)
services/panel-main.c (+8/-0)
services/panel-service.c (+15/-0)
services/panel-service.h (+2/-0)
tests/CMakeLists.txt (+1/-1)
tests/mock_indicators.h (+1/-0)
tests/test_lockscreen_controller.cpp (+10/-2)
tests/test_main_xless.cpp (+4/-5)
tests/test_previews_music_payment.cpp (+1/-0)
tests/test_text_input.cpp (+1/-0)
tools/migration-scripts/03_unity_first_run_stamp_move (+35/-0)
unity-shared/CompizUtils.cpp (+77/-58)
unity-shared/CompizUtils.h (+36/-5)
unity-shared/DashStyle.cpp (+8/-11)
unity-shared/DecorationStyle.cpp (+2/-2)
unity-shared/GnomeKeyGrabber.cpp (+9/-0)
unity-shared/IconRenderer.cpp (+73/-43)
unity-shared/IconRenderer.h (+0/-2)
unity-shared/IconTexture.cpp (+1/-1)
unity-shared/IconTextureSource.cpp (+37/-1)
unity-shared/IconTextureSource.h (+10/-4)
unity-shared/LayoutSystem.cpp (+28/-4)
unity-shared/LayoutSystem.h (+2/-1)
unity-shared/PluginAdapter.cpp (+39/-2)
unity-shared/PluginAdapter.h (+3/-0)
unity-shared/SearchBar.cpp (+18/-12)
unity-shared/SearchBar.h (+9/-9)
unity-shared/SearchBarSpinner.h (+0/-2)
unity-shared/SpreadFilter.cpp (+3/-1)
unity-shared/StandaloneWindowManager.h (+2/-0)
unity-shared/TextInput.cpp (+138/-76)
unity-shared/TextInput.h (+17/-19)
unity-shared/UScreen.cpp (+26/-4)
unity-shared/UScreen.h (+0/-1)
unity-shared/UnitySettings.cpp (+9/-1)
unity-shared/WindowManager.h (+5/-0)
unity-shared/XWindowManager.cpp (+1/-1)
Changed in unity: | |
status: | New → Incomplete |
tags: | added: needs-design |
description: | updated |
tags: |
added: udp removed: needs-design |
Changed in ayatana-design: | |
assignee: | nobody → John Lea (johnlea) |
importance: | Undecided → Low |
Changed in unity: | |
importance: | Undecided → Low |
Changed in ayatana-design: | |
status: | New → Fix Committed |
Changed in unity: | |
status: | Incomplete → Fix Committed |
Changed in unity (Ubuntu): | |
status: | New → Fix Committed |
Changed in unity: | |
status: | Fix Committed → Triaged |
Changed in unity (Ubuntu): | |
status: | Fix Committed → Confirmed |
summary: |
- "Show Desktop" doesn't produce desired action + Change "Show Desktop" ALT-TAB option label when this option is in the + state where it will reverse the prior show desktop action. |
Changed in unity: | |
milestone: | none → 7.2.1 |
Changed in unity (Ubuntu): | |
status: | Confirmed → Triaged |
importance: | Undecided → Low |
Changed in unity: | |
milestone: | 7.2.1 → 7.2.2 |
Changed in unity: | |
milestone: | 7.2.2 → 7.2.3 |
Changed in unity: | |
milestone: | 7.2.3 → 7.3.1 |
summary: |
- Change "Show Desktop" ALT-TAB option label when this option is in the - state where it will reverse the prior show desktop action. + Change "Show Desktop" icon option label when this option is in the state + where it will reverse the prior show desktop action. |
Changed in unity: | |
status: | In Progress → Fix Committed |
description: | updated |
Changed in unity: | |
status: | Fix Committed → Fix Released |
See: https:/ /bugs.launchpad .net/unity/ +bug/966030/ comments/ 19
Thanks!