Ubuntu
upstart-app-launch package

Adds spaces when processing --xyz=%u args

Bug #1227632 reported by Loïc Minier
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Application Launcher
Fix Released
Undecided
Unassigned
upstart-app-launch (Ubuntu)
Fix Released
High
Unassigned

Bug Description

Hi,

When trying to launch music-app from music home scope on a music file, the resulting cmdline has superfluous space:
/usr/lib/arm-linux-gnueabihf/qt5/bin/qmlscene /usr/share/music-app/music-app.qml --file= file:///home/phablet/Music/xyz.flac --desktop_file_hint=/usr/share/applications/music-app.desktop

that is, --file=%u became two args, --file= and the URL

I think this is in helpers.c/desktop_exec_parse() because it splits the string on % but joins it on " " instead of just joining the bits.

Cheers,

Related branches

lp:~lool/ubuntu-app-launch/lp-1227632
Ted Gould (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 12 lines (+1/-1)
1 file modified
helpers.c (+1/-1)
lp:ubuntu/saucy-proposed/upstart-app-launch
Loïc Minier (lool)
Changed in upstart-app-launch (Ubuntu):
importance: Undecided → High
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:upstart-app-launch at revision 58, scheduled for release in upstart-app-launch, milestone Unknown

Changed in upstart-app-launch:
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package upstart-app-launch - 0.1+13.10.20130919.3-0ubuntu1

---------------
upstart-app-launch (0.1+13.10.20130919.3-0ubuntu1) saucy; urgency=low

  [ Loïc Minier ]
  * Fix LP #1227632 by directly joining the components of the Exec line
    split on % instead of joining them with spaces. (LP: #1227632)

  [ Ted Gould ]
  * Only split the URIs if there are more than one.
  * Try to deduce if we're on Surface Flinger.

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 58
 -- Ubuntu daily release <email address hidden> Thu, 19 Sep 2013 14:03:55 +0000

Changed in upstart-app-launch (Ubuntu):
status: New → Fix Released
Loïc Minier (lool)
Changed in upstart-app-launch:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.