apiserver.common.ServerError needs to handle unhashable errors
Bug #1217760 reported by
John A Meinel
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| juju-core |
Fix Released
|
Critical
|
John A Meinel | ||
Bug Description
ServerError is meant to handle all types and just wrap them as appropriate.
However, if err is unhashable ,then the map lookup panics and prevents us from getting to the 'default' code.
In practice we are seeing some sort of "schema.error_" bubble up and trigger a giant panic traceback.
Related branches
lp:~jameinel/juju-core/unhashable-errors-1217760
- Juju Engineering: Pending requested
-
Diff: 110 lines (+49/-15)2 files modifiedstate/apiserver/common/errors.go (+25/-14)
state/apiserver/common/errors_test.go (+24/-1)
lp:~rogpeppe/juju-core/377-fix-server-error
- Juju Engineering: Pending requested
-
Diff: 66 lines (+23/-3)2 files modifiedstate/apiserver/common/errors.go (+13/-2)
state/apiserver/common/errors_test.go (+10/-1)
| tags: | added: cts |
Revision history for this message
| Dave Cheney (dave-cheney) wrote | #1 |
Revision history for this message
| John A Meinel (jameinel) wrote Re: [Bug 1217760] Re: apiserver.common.ServerError needs to handle unhashable errors | #2 |
| Changed in juju-core: | |
| status: | In Progress → Fix Committed |
| Changed in juju-core: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
@jam: does this block the 1.13.3 release ?