vdr-plugin-xine: FTBFS with current vdr

Bug #1198020 reported by Logan Rosen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
vdr-plugin-xine (Debian)
Fix Released
Unknown
vdr-plugin-xine (Ubuntu)
Fix Released
High
Unassigned

Bug Description

Imported from Debian bug http://bugs.debian.org/709031:

Package: vdr-plugin-xine
Version: 0.9.4-7
Severity: serious
User: <email address hidden>
Usertags: origin-ubuntu saucy

vdr-plugin-xine fails to build with the current vdr in unstable, as
shown in this Ubuntu build log:

  g++ -g -O3 -Wall -Woverloaded-virtual -c -D_GNU_SOURCE -DPLUGIN_NAME_I18N='"xine"' -DFIFO_DIR=\"/tmp/vdr-xine\" -DVERIFY_BITMAP_DIRTY=0 `pkg-config --cflags libxine` -I/usr/include/vdr/include xineDevice.c
  [...]
  xineDevice.c: In member function 'virtual void PluginXine::cXineDevice::StillPicture(const uchar*, int)':
  xineDevice.c:1203:36: error: 'class cPatPmtParser' has no member named 'PmtPid'
         else if (pid == patPmtParser.PmtPid())
                                      ^
  xineDevice.c:1403:1: warning: narrowing conversion of '(vdr172::cRemux::IsFrameH264(Data, Length) ? 10 : 183)' from 'int' to 'uchar {aka unsigned char}' inside { } is ill-formed in C++11 [-Wnarrowing]
   };
   ^
  xineDevice.c: In member function 'void PluginXine::cXineDevice::mainMenuTrampoline()':
  xineDevice.c:4230:79: warning: ignoring return value of 'int asprintf(char**, const char*, ...)', declared with attribute warn_unused_result [-Wunused-result]
         ::asprintf(&msg, tr("Switching primary DVB to %s..."), m_plugin->Name());
                                                                                 ^
  xineDevice.c:4241:82: warning: ignoring return value of 'int asprintf(char**, const char*, ...)', declared with attribute warn_unused_result [-Wunused-result]
         ::asprintf(&msg, tr("Switched primary DVB back from %s"), m_plugin->Name());
                                                                                    ^
  [...]
  make[2]: *** [xineDevice.o] Error 1

I looked into fixing this, but I don't know the code well enough. There
is a definition of cPatPmtParser::PmtPid, but it's inside an "#if 0"
block, along with the rest of class cPatPmtParser. In fact there are
several fairly large "#if 0" blocks; this is the sort of thing I'd
expect to see in somebody's experimental branch, not in released code.
Furthermore the upstream web site appears to have vanished and so I
can't trace through version control to try to work out what's going on.
Perhaps you have a better idea?

Thanks,

--
Colin Watson [<email address hidden>]

Tags: ftbfs
Logan Rosen (logan)
Changed in vdr-plugin-xine (Ubuntu):
status: New → Triaged
importance: Undecided → High
tags: added: ftbfs
Changed in vdr-plugin-xine (Debian):
importance: Undecided → Unknown
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package vdr-plugin-xine - 0.9.4-11ubuntu1

---------------
vdr-plugin-xine (0.9.4-11ubuntu1) trusty; urgency=low

  * debian/patches/vdr-1.7.33.patch: Use APIVERSUM to determine vdr
    version to fix FTBFS: 'class cPatPmtParser' has no member named 'PmtPid'
    (Closes: #709031) (LP: #1198020)
  * debian/patches/vdr-1.7.40.patch: Apply patch from
    Lucian Muresan lucianm.AT.users.sourceforge.net to build with newer
    vdr versions to fix: error: 'vidWin' was not declared in this scope
 -- Andreas Moog <email address hidden> Thu, 28 Nov 2013 23:12:16 +0100

Changed in vdr-plugin-xine (Ubuntu):
status: Triaged → Fix Released
Changed in vdr-plugin-xine (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.