Add City needs to show states in US
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Clock App |
Fix Released
|
Medium
|
Riccardo Padovani |
Bug Description
The "add city" feature in the clock does not differentiate between cities in different states. It is common for a US state to have city/town that shares the name of a city/town in another state. For example, there are at least a dozen states that have a city/town called 'Springfield'. In this situation the list of cities shows multiple identical entries; the user has to guess which one is appropriate
To reproduce:
1) Launch clock app
2) Swipe up from bottom to reveal to "Add City" button
3) Tap "Add City"
4) In the search box, search for "Springfield"
Expected results:
Search results differentiate between different towns with the same name, e.g. "Springfield, Massachusetts, USA" and "Springfield, Missouri, USA"
Actual results:
Search results contain multiple "Springfield, USA" entries.
I'm using the saucy-31 build on a Nexus 7
-------
This bug is quite trivial to fix. The online API from which the data is gathered does actually provide the state info if the "style=full" parameter is added to the url.
1. In the WorldClock.qml, append "style=full" in the searchCityUrl() function.
2. Append the searchCityModel XmlListModel to get the info from the adminName1 xml element in the online API.
3. In the ListView which shows the results, add the state from the XmlListModel.
The final search URL will be something like http://
Dificulty: Easy
Test your fix and propose merge!
Related branches
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Nekhelesh Ramananthan: Approve
-
Diff: 29 lines (+3/-2)1 file modifiedclock/WorldClock.qml (+3/-2)
Changed in ubuntu-clock-app: | |
status: | New → Triaged |
importance: | Undecided → Medium |
milestone: | none → coreapps-13.10-month-3 |
assignee: | nobody → Nekhelesh Ramananthan (nik90) |
Changed in ubuntu-clock-app: | |
status: | Triaged → In Progress |
tags: | added: hackday |
Changed in ubuntu-clock-app: | |
assignee: | Nekhelesh Ramananthan (nik90) → nobody |
status: | In Progress → Triaged |
description: | updated |
description: | updated |
description: | updated |
description: | updated |
Changed in ubuntu-clock-app: | |
assignee: | nobody → Riccardo Padovani (rpadovani) |
Changed in ubuntu-clock-app: | |
status: | Triaged → In Progress |
Changed in ubuntu-clock-app: | |
status: | Fix Committed → Fix Released |
This seems to be due to a limitation of the online API service. I have already reported it. Waiting for their response.