Merge lp:~rpadovani/ubuntu-clock-app/1197436 into lp:ubuntu-clock-app/saucy

Proposed by Riccardo Padovani
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 137
Merged at revision: 137
Proposed branch: lp:~rpadovani/ubuntu-clock-app/1197436
Merge into: lp:ubuntu-clock-app/saucy
Diff against target: 29 lines (+3/-2)
1 file modified
clock/WorldClock.qml (+3/-2)
To merge this branch: bzr merge lp:~rpadovani/ubuntu-clock-app/1197436
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Nekhelesh Ramananthan Approve
Review via email: mp+174380@code.launchpad.net

Commit message

Added adminName to WorldCity, see #1197436

Description of the change

Added adminName to WorldCity, see #1197436

To post a comment you must log in.
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

lgtm! Nice work!

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Reapproving since build failed due to jenkin bots failing while try to merge branch.

Build step 'Debian PBuilder NG' marked build as failure
Looks like the node went offline during the build. Check the slave log for the details.
FATAL: channel is already closed
hudson.remoting.ChannelClosedException: channel is already closed
 at hudson.remoting.Channel.send(Channel.java:486)
 at hudson.remoting.Request.call(Request.java:110)
 at hudson.remoting.Channel.call(Channel.java:668)
 at hudson.Launcher$RemoteLauncher.kill(Launcher.java:812)
 at hudson.model.AbstractBuild$AbstractRunner.run(AbstractBuild.java:481)
 at hudson.model.Run.run(Run.java:1376)
 at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46)
 at hudson.model.ResourceController.execute(ResourceController.java:88)
 at hudson.model.Executor.run(Executor.java:175)
Caused by: java.net.SocketException: Socket closed
 at java.net.SocketInputStream.socketRead0(Native Method)
 at java.net.SocketInputStream.read(SocketInputStream.java:146)
 at java.io.BufferedInputStream.fill(BufferedInputStream.java:235)
 at java.io.BufferedInputStream.read(BufferedInputStream.java:254)
 at java.io.ObjectInputStream$PeekInputStream.peek(ObjectInputStream.java:2290)
 at java.io.ObjectInputStream$BlockDataInputStream.peek(ObjectInputStream.java:2583)
 at java.io.ObjectInputStream$BlockDataInputStream.peekByte(ObjectInputStream.java:2593)
 at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1315)
 at java.io.ObjectInputStream.readObject(ObjectInputStream.java:369)
 at hudson.remoting.Channel$ReaderThread.run(Channel.java:1031)

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'clock/WorldClock.qml'
2--- clock/WorldClock.qml 2013-07-09 17:21:12 +0000
3+++ clock/WorldClock.qml 2013-07-12 11:10:30 +0000
4@@ -30,7 +30,7 @@
5 signal clicked()
6
7 function searchCityUrl (city) {
8- return (search_base_url + search_string + "&maxRows=" + no_of_results + "&username=" + username);
9+ return (search_base_url + search_string + "&maxRows=" + no_of_results + "&username=" + username + "&style=full");
10 }
11
12 function localCityUrl () {
13@@ -62,6 +62,7 @@
14 XmlRole { name: "country"; query: "countryName/string()"; isKey: true }
15 XmlRole { name: "lat"; query: "lat/string()"; isKey: true }
16 XmlRole { name: "lng"; query: "lng/string()"; isKey: true }
17+ XmlRole { name: "adminName"; query: "adminName1/string()"; isKey: true}
18
19 onSourceChanged: reload();
20 }
21@@ -141,7 +142,7 @@
22
23 delegate: ListItem.Standard {
24 Label {
25- text: searchCityModel.status == XmlListModel.Ready ? city + ", " + country : i18n.tr("Loading");
26+ text: searchCityModel.status == XmlListModel.Ready ? (adminName ? (city + ", " + adminName + ", " + country) : (city + ", " + country)) : i18n.tr("Loading");
27 anchors { verticalCenter: parent.verticalCenter; left: parent.left; leftMargin: units.gu(3) }
28 fontSize: "large"
29 }

Subscribers

People subscribed via source and target branches