Sudoku App

No way to cancel in "pick a number" screen

Bug #1196473 reported by Alan Pope 🍺🐧🐱 🦄
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sudoku App
Fix Released
Undecided
Frédéric Delgado

Bug Description

If you mis-tap and hit the wrong button when tapping, you will be taken to the usual "Please pick a number" dialog. In that you have options to "clear" or enter a number from 1 to 9. There is no "cancel" option. I would expect to be able to cancel this dialog. Otherwise my only option is to try and see the number which was in the box through the tinted background, or clear it and then try and re-calculate what it was and re-enter the "pick a number" screen to fill it in.

Frédéric Delgado (fredoust)
Changed in sudoku-app:
assignee: nobody → Frédéric Delgado (fredoust)
Frédéric Delgado (fredoust)
Changed in sudoku-app:
status: New → Fix Committed
Revision history for this message
Dinko Osmankovic (dinko-metalac) wrote :

You can press clear. Is that working?

Revision history for this message
Frédéric Delgado (fredoust) wrote :

If you press clear, the dialog is closed but the sudoku block is empty, I think what Alan want to say is to add the possibilité to close the dialog without empty the sudoku block.

I added a cancel button in my revison #55.

Revision history for this message
Dinko Osmankovic (dinko-metalac) wrote :

Aha, I see. Great then. Can you request merge for these bugs so we can merge it with trunk?

Revision history for this message
Frédéric Delgado (fredoust) wrote :

Ok it's done, I didn't know I had to propose for merging.
I also created two folders in the project : components and js, hope this is not a problem.

Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

For future reference the process for merging goes a bit like this:-

# get latest from trunk
bzr branch lp:sudoku-app

# create local branch for fixing
bzr branch sudoku-app fix-bug-1196473

# Fix stuff!
cd fix-bug-1196473
# Write awesome code here!

# Commit changes
bzr commit -m "Fix for bug 1196473 by adding some js and other stuff"

# Push changes to your own branch
bzr push lp:fredoust/sudoku-app/fix-bug-1196473

At this point it's pushed into launchpad.

# Link to bug
https://bugs.launchpad.net/sudoku-app/+bug/1196473 -> click "Link a related branch" on the right, it should suggest yours, if not find it via the search for "fix-bug-1196473" you used above.

# Propose for merging
Then go to http://code.launchpad.net/~fredoust/sudoku-app/fix-bug-1196473 (once pushed above) and click the link to create a merge proposal. It should already know this was branched from sudoku-app, so accept the default. You can optionally choose someone to review your merge request. If you don't fill that in, it goes to all members of the team to review. They show up here:- https://code.launchpad.net/sudoku-app/+activereviews

Dinko Osmankovic (dinko-metalac)
Changed in sudoku-app:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.