Checkbox

fwts_test can generate incorrect data for suspend-time log

Bug #1188221 reported by Brendan Donegan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox
Fix Released
High
Brendan Donegan

Bug Description

The fwts_test script writes a log for recording the amount of time taken to suspend the system and to resume from that suspend. This is calculated based on the timestamps in /var/log/syslog. Unfortunately an assumption it makes can be wrong. It expects the last thing it sees before the resume has completed to be:

"PM: Finishing wakeup."

Sometimes this is not the case though, and we get a negative number for the wakeup time.

It also seems this can happen for calculating the time taken to suspend.

Tags: scripts

Related branches

lp:~bladernr/checkbox/1188221-fix-sleep-tests
Daniel Manrique (community): Approve
Diff: 48 lines (+6/-3)
3 files modified
checkbox-old/debian/changelog (+3/-0)
checkbox-old/scripts/fwts_test (+1/-1)
checkbox-old/scripts/sleep_test (+2/-2)
lp:ubuntu/saucy/checkbox
Brendan Donegan (brendan-donegan)
Changed in checkbox:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Brendan Donegan (brendan-donegan)
Daniel Manrique (roadmr)
tags: added: scripts
Revision history for this message
Jeff Lane  (bladernr) wrote :

Need copies of the time log and syslog for failing scenarios

Revision history for this message
Jeff Lane  (bladernr) wrote :

The problem is that the marker used to determine when the system awoke was actually a debug message, not a standard printk (see kernel/power/suspend.c). At some point in recent history, someone turned off the debug messages to quiet the console down. This led to the issues Brendan observed.

The fix was to look for a different message. After discussing with cking, we decided to change the marker to the "Restarting tasks" message instead as that appears to be more reliable or at least shouldn't be affected by further quieting of console messages in the foreseeable future.

Changed in checkbox:
status: Confirmed → In Progress
Daniel Manrique (roadmr)
Changed in checkbox:
status: In Progress → Fix Committed
Brendan Donegan (brendan-donegan)
Changed in checkbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.