Resetting root pw on restore is subject to a race condition

Bug #1187958 reported by Nikhil Manchanda
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
High
Nikhil Manchanda

Bug Description

When an instance is restored from a backup, during the step when the root password is being reset, it is possible that the mysql_safe process is killed before the actual reset password takes place (from init-file).

This needs to be fixed so that there is no race condition here.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to reddwarf (master)

Fix proposed to branch: master
Review: https://review.openstack.org/31905

Changed in reddwarf:
assignee: nobody → Nikhil Manchanda (slicknik)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to reddwarf (master)

Reviewed: https://review.openstack.org/31905
Committed: http://github.com/stackforge/reddwarf/commit/44c0dba4c6404dee3be2d2d7e9aeb70ea59a6647
Submitter: Jenkins
Branch: master

commit 44c0dba4c6404dee3be2d2d7e9aeb70ea59a6647
Author: Nikhil Manchanda <email address hidden>
Date: Wed Jun 5 19:07:03 2013 -0700

    Fixed race condition in the Restore workflow

    When an instance is restored from a backup, during the step when the root
    password is being reset, we now check to ensure that the mysqld daemon is
    up, before we kill the process. This ensures that the root password is
    always reset successfully.

    Fixes bug 1187958

    Change-Id: If5a5c0293c0dc51c3f118abbcc52c3fb0d1d3cfa

Changed in reddwarf:
status: In Progress → Fix Committed
Changed in reddwarf:
milestone: none → havana-2
Changed in trove:
importance: Undecided → High
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.