Undeclared identifier in bamf-application.c

Bug #1186915 reported by Maxime Gauduin
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
BAMF
Fix Released
High
Marco Trevisan (Treviño)
bamf (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Latest bzr fails to build on Arch Linux with GCC 4.8.1. Please find the relevant build log part below.

bamf-application.c: In function 'bamf_application_load_data_from_file':
bamf-application.c:646:44: error: 'G_KEY_FILE_DESKTOP_KEY_FULLNAME' undeclared (first use in this function)
                                            G_KEY_FILE_DESKTOP_KEY_FULLNAME, NULL, NULL);
                                            ^
bamf-application.c:646:44: note: each undeclared identifier is reported only once for each function it appears in
make[3]: *** [libbamf3_la-bamf-application.lo] Error 1

Related branches

Revision history for this message
Bas Dalenoord (bdalenoord) wrote :

I've created a workaround for this bug for now, by commenting out the affected lines and adding a 'fullname=NULL;' statement afterwards. I am however not sure what the effects of this are. The lines below 646 did something similar though so I guess it is not really affecting functionality.

Changed in bamf:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
importance: Medium → High
milestone: none → 0.5.0
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:bamf at revision 542, scheduled for release in bamf, milestone 0.5.0

Changed in bamf:
status: In Progress → Fix Committed
Changed in bamf:
status: Fix Committed → In Progress
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:bamf at revision 543, scheduled for release in bamf, milestone 0.5.0

Changed in bamf:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package bamf - 0.5.0daily13.06.19-0ubuntu1

---------------
bamf (0.5.0daily13.06.19-0ubuntu1) saucy; urgency=low

  [ Marco Trevisan (Treviño) ]
  * New upstream release, bumping debian version to 0.5.0
  * LibBamfPrivate: add new private library to share code between client
    and daemon.
  * libbamf, BamfView: Use dbus-properties (both values and signals) It
    allows to have correct values and signals when they get updated.
    Deprecating related dbus methods/signals.
  * debian/control:
    - don't build-depend anymore on libdbus-glib-1-dev

  [ Jeremy Bicha ]
  * debian/control:
    - Have libbamf3-dev depend on gir1.2-bamf-3
    - Drop explicit build-depends on gir1.2-glib-2.0

  [ Ted Gould ]
  * Have bamfdaemon depend on the library instead of vice versa.

  [ Marco Trevisan (Treviño) ]
  * Makefile.am.gtests: kill the launched dbus-daemon after running the
    tests. (LP: #1088696, #1186915)
  * BamfDaemon, LibBamf: Fix compilation errors out from ubuntu. (LP:
    #1186915, #1176524)
  * BamfView: use statically allocated pspec to notify property changes
    BamfFactory: some initial cleanup, remove views that have changed
    their path and use cached children.
  * BamfView: use incremental children caching, delete them only when
    daemon stops Each view used to cleanup the cached children every
    time a new one was added or removed. This was needed at the dbus-
    glib times to handle the case of bamfdaemon restart, but now we can
    handle this nicely, clening the children up only when this happens.
  * BamfView: disconnect proper callback if a bamf-tab is closed I guess
    it was a typo, we need to disconnect to the callback we've been
    connected to before.
  * BamfView: don't try to reload the children if they're empty but we
    already tried once This finally mutes the "Unable to fetch children"
    warning... \o/. (LP: #943083)
  * Bamf: use generic marshallers when creating signals, remove legacy
    bamf-marshal Improvements to the build system, fixed "make
    distcheck" (it was still referencing the old bamf.h file) and
    generation of files when using parallel builds (make -jX).
  * BamfMatcher: If a Window has changed its class, then we try to
    rematch it This is mostly the case of LibreOffice, but if a window
    has changed its class, then we should try to re-match, checking if
    now it can be matched by a new application. If this is the case,
    then we remove the window from the previous application (that may
    eventually be closed) and we add it to the new one. Thanks to this
    we can finally remove a lot of libreoffice-only related code.

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 554
 -- Ubuntu daily release <email address hidden> Wed, 19 Jun 2013 02:01:25 +0000

Changed in bamf (Ubuntu):
status: New → Fix Released
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Fix Released in Bamf BAMF 0.5.0.

Changed in bamf:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.