Allow multiple preview diffs per MP
Bug #1179335 reported by
Steve Kowalik
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Steve Kowalik | ||
Bug Description
Currently, the foreign key for a preview diff is keyed from the BranchMergeProp
Related branches
lp:~stevenk/launchpad/db-previewdiff-to-bmp
- Stuart Bishop (community): Approve (db)
- William Grant: Pending (db) requested
-
Diff: 17 lines (+13/-0)1 file modifieddatabase/schema/patch-2209-44-0.sql (+13/-0)
lp:~stevenk/launchpad/populate-previewdiff-merge_proposal
- William Grant: Approve (code)
-
Diff: 434 lines (+125/-39)14 files modifieddatabase/schema/security.cfg (+1/-0)
lib/lp/code/browser/tests/test_branchmergeproposal.py (+1/-1)
lib/lp/code/doc/branch-merge-proposal-notifications.txt (+2/-1)
lib/lp/code/interfaces/diff.py (+7/-0)
lib/lp/code/mail/tests/test_branchmergeproposal.py (+9/-14)
lib/lp/code/mail/tests/test_codehandler.py (+3/-4)
lib/lp/code/model/branchmergeproposal.py (+1/-1)
lib/lp/code/model/diff.py (+27/-8)
lib/lp/code/model/tests/test_branchmergeproposal.py (+5/-5)
lib/lp/code/stories/branches/xx-branchmergeproposal-listings.txt (+2/-1)
lib/lp/code/stories/branches/xx-branchmergeproposals.txt (+3/-2)
lib/lp/scripts/garbo.py (+47/-1)
lib/lp/scripts/tests/test_garbo.py (+15/-0)
lib/lp/testing/factory.py (+2/-1)
lp:~stevenk/launchpad/index-previewdiff-merge_proposal
- William Grant: Approve (db)
-
Diff: 13 lines (+9/-0)1 file modifieddatabase/schema/patch-2209-44-1.sql (+9/-0)
lp:~stevenk/launchpad/switch-bmp-to-previewdiff-merge_proposal
- William Grant: Approve (code)
-
Diff: 660 lines (+135/-140)14 files modifiedlib/lp/code/browser/tests/test_branchmergeproposal.py (+4/-6)
lib/lp/code/browser/tests/test_branchmergeproposallisting.py (+1/-1)
lib/lp/code/doc/branch-merge-proposal-notifications.txt (+9/-12)
lib/lp/code/interfaces/branchmergeproposal.py (+2/-0)
lib/lp/code/mail/tests/test_branchmergeproposal.py (+6/-9)
lib/lp/code/mail/tests/test_codehandler.py (+2/-7)
lib/lp/code/model/branchmergeproposal.py (+35/-29)
lib/lp/code/model/branchmergeproposaljob.py (+3/-5)
lib/lp/code/model/diff.py (+9/-35)
lib/lp/code/model/tests/test_branchcollection.py (+45/-12)
lib/lp/code/model/tests/test_branchmergeproposal.py (+1/-1)
lib/lp/code/stories/branches/xx-branchmergeproposal-listings.txt (+2/-5)
lib/lp/code/stories/branches/xx-branchmergeproposals.txt (+8/-10)
lib/lp/testing/factory.py (+8/-8)
lp:~stevenk/launchpad/drop-branchmergeproposal-merge_diff
- Stuart Bishop (community): Approve (db)
- William Grant: Pending (db) requested
-
Diff: 24 lines (+8/-1)2 files modifieddatabase/schema/comments.sql (+0/-1)
database/schema/patch-2209-44-2.sql (+8/-0)
lp:~stevenk/launchpad/set-previewdiff-merge_proposal-not-null
- Stuart Bishop (community): Approve (db)
- William Grant: Pending (db) requested
-
Diff: 13 lines (+9/-0)1 file modifieddatabase/schema/patch-2209-44-3.sql (+9/-0)
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: |
added: qa-needstesting removed: qa-ok |
| tags: |
added: qa-ok removed: qa-needstesting |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #3 |
| tags: |
added: qa-needstesting removed: qa-ok |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #4 |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #5 |
| tags: |
added: qa-needstesting removed: qa-ok |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad: | |
| status: | Fix Committed → In Progress |
| tags: |
added: qa-ok removed: qa-needstesting |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #6 |
| tags: |
added: qa-needstesting removed: qa-ok |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in db-stable r12412 <http://