Merge lp:~stevenk/launchpad/drop-branchmergeproposal-merge_diff into lp:launchpad/db-devel

Proposed by Steve Kowalik
Status: Merged
Approved by: Steve Kowalik
Approved revision: no longer in the source branch.
Merged at revision: 12422
Proposed branch: lp:~stevenk/launchpad/drop-branchmergeproposal-merge_diff
Merge into: lp:launchpad/db-devel
Prerequisite: lp:~stevenk/launchpad/switch-bmp-to-previewdiff-merge_proposal
Diff against target: 24 lines (+8/-1)
2 files modified
database/schema/comments.sql (+0/-1)
database/schema/patch-2209-44-2.sql (+8/-0)
To merge this branch: bzr merge lp:~stevenk/launchpad/drop-branchmergeproposal-merge_diff
Reviewer Review Type Date Requested Status
Stuart Bishop (community) db Approve
William Grant db Pending
Review via email: mp+162917@code.launchpad.net

Commit message

Drop the BranchMergeProposal.merge_diff column.

Description of the change

Dump BranchMergeProposal.merge_diff as our last step.

To post a comment you must log in.
Revision history for this message
Stuart Bishop (stub) wrote :

Yup

review: Approve (db)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'database/schema/comments.sql'
2--- database/schema/comments.sql 2013-02-06 11:44:37 +0000
3+++ database/schema/comments.sql 2013-05-16 05:59:39 +0000
4@@ -135,7 +135,6 @@
5 COMMENT ON COLUMN BranchMergeProposal.dependent_branch IS 'If the source branch was not branched off the target branch, then this is considered the dependent_branch.';
6 COMMENT ON COLUMN BranchMergeProposal.date_created IS 'When the registrant created the merge proposal.';
7 COMMENT ON COLUMN BranchMergeProposal.whiteboard IS 'Used to write other information about the branch, like test URLs.';
8-COMMENT ON COLUMN BranchMergeProposal.merge_diff IS 'The diff showing the predicted result of a merge.';
9 COMMENT ON COLUMN BranchMergeProposal.merged_revno IS 'This is the revision number of the revision on the target branch that includes the merge from the source branch.';
10 COMMENT ON COLUMN BranchMergeProposal.merge_reporter IS 'This is the user that marked the proposal as merged.';
11 COMMENT ON COLUMN BranchMergeProposal.date_merged IS 'This is the date that merge occurred.';
12
13=== added file 'database/schema/patch-2209-44-2.sql'
14--- database/schema/patch-2209-44-2.sql 1970-01-01 00:00:00 +0000
15+++ database/schema/patch-2209-44-2.sql 2013-05-16 05:59:39 +0000
16@@ -0,0 +1,8 @@
17+-- Copyright 2013 Canonical Ltd. This software is licensed under the
18+-- GNU Affero General Public License version 3 (see the file LICENSE).
19+
20+SET client_min_messages=ERROR;
21+
22+ALTER TABLE branchmergeproposal DROP COLUMN merge_diff;
23+
24+INSERT INTO LaunchpadDatabaseRevision VALUES (2209, 44, 2);

Subscribers

People subscribed via source and target branches

to status/vote changes: