Window with two untranslated and untranslatable buttons

Bug #1176695 reported by londumas
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Checkbox
Fix Released
High
Daniel Manrique
Ubuntu Translations
Fix Released
Low
Unassigned

Bug Description

1/
Description: Ubuntu 13.04
Release: 13.04

2/
checkbox:
  Installé : 0.15.5
  Candidat : 0.15.5
 Table de version :
 *** 0.15.5 0
        500 http://th.archive.ubuntu.com/ubuntu/ raring/main amd64 Packages
        100 /var/lib/dpkg/status

3/ - 4/
After having left an ongoing test, when you come back, you have a window asking you if you want to restart, return or continue.
Two of these buttons are untranslated (in French) and seem not to be in the Launchpad translatable list.
(see picture)

Related branches

Revision history for this message
londumas (helion331990) wrote :
Revision history for this message
Daniel Manrique (roadmr) wrote :

Hello, thanks for reporting this!

These buttons *should* be translatable. However, due to the somewhat convoluted way we access the translations, in practice the strings aren't added to the catalog. The extraction script looks for text wrapped in the gettext call, so for instance this will get picked up for the catalog:

_("Restart")

However, what we do is something like this:
RESTART_TEXT="Restart"
CONTINUE_TEXT="Continue"
RESET_TEXT="Reset"

then:
text = [RESTART_TEXT, CONTINUE_TEXT, RESET_TEXT]
translated_text = [_(txt) for txt in text]

The extraction script is then not clever enough to run the list comprehension to figure out it should extract the strings.

The solution will most likely involve doing something like:
RESTART_TEXT=_("Restart")
CONTINUE_TEXT=_("Continue")
RESET_TEXT=_("Reset")

However, care must be taken not to simply do this, since we need to consider that the Qt user interface sends unicode-encoded strings and this needs to be handled carefully. Specifically, look at checkbox commit 1364 and subcommit 1362.1.3 under that, to understand what was done and the behavior we need to keep.

Changed in checkbox:
importance: Undecided → High
status: New → Triaged
assignee: nobody → Daniel Manrique (roadmr)
Revision history for this message
Daniel Manrique (roadmr) wrote :

One more thing :) The reason why the "Continue" string is correctly translated ("Poursuivre" in the screenshot, is that "Continue" *is* included in the catalog (since it's present in another file), and gettext helpfully used that translation here.

Daniel Manrique (roadmr)
Changed in checkbox:
status: Triaged → In Progress
Daniel Manrique (roadmr)
Changed in checkbox:
status: In Progress → Fix Committed
Revision history for this message
londumas (helion331990) wrote :

Thanks to have taken my repport into consideration.

Revision history for this message
Hendrik Schrieber (hennekn) wrote :

Still a problem in 13.10.

Changed in ubuntu-translations:
status: New → Confirmed
Revision history for this message
Hendrik Schrieber (hennekn) wrote :

False alarm I guess. Looks like this will be released for Saucy soon.

Changed in checkbox:
status: Fix Committed → Fix Released
Changed in ubuntu-translations:
status: Confirmed → Fix Released
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.