oslo-incubator

Lockutils - deletes directory rendering locks invalid

Bug #1158179 reported by Gary Kotton
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
High
John Griffith
Cinder 2013.1 "grizzly"
Folsom
Won't Fix
High
Rushi Agrawal
OpenStack Compute (nova)
Fix Released
High
Russell Bryant
OpenStack Compute (nova) 2013.1 "grizzly"
neutron
Fix Released
High
Gary Kotton
neutron 2013.1 "grizzly"
oslo-incubator
Fix Released
High
Gary Kotton
oslo-incubator 2013.2 "havana"
Grizzly
Fix Committed
High
Gary Kotton

Bug Description

There is an edge case as follows:
    process A takes lock
    process B waits on lock
    process A completed work
    process B takes lock
    process A takes lock (this is without process B freeing the lock)

This is reproduced very easily:
    ensure that the lock_path directory does not exist

Each time a lock is freed the directory is deleted ...

See original description
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo-incubator (master)

Fix proposed to branch: master
Review: https://review.openstack.org/24975

Changed in oslo:
assignee: nobody → Gary Kotton (garyk)
status: New → In Progress
Vish Ishaya (vishvananda)
Changed in nova:
importance: Undecided → High
Gary Kotton (garyk)
Changed in quantum:
milestone: none → grizzly-rc2
assignee: nobody → Gary Kotton (garyk)
tags: added: grizzly-backport-potential
Mark McClain (markmcclain)
Changed in quantum:
importance: Undecided → High
Thierry Carrez (ttx)
tags: added: grizzly-rc-potential
removed: grizzly-backport-potential
OpenStack Infra (hudson-openstack)
Changed in oslo:
assignee: Gary Kotton (garyk) → Mark McLoughlin (markmc)
Revision history for this message
Mark McLoughlin (markmc) wrote :

See bug #1065531 for where we need to go on this beyond the initial, safe fix

tags: added: folsom-backport-potential
Changed in oslo:
importance: Undecided → High
assignee: Mark McLoughlin (markmc) → Gary Kotton (garyk)
Mark McLoughlin (markmc)
Changed in nova:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo-incubator (master)

Reviewed: https://review.openstack.org/24975
Committed: http://github.com/openstack/oslo-incubator/commit/88d316f0be89d8fe1cc5616091e0ceb47abfd55f
Submitter: Jenkins
Branch: master

commit 88d316f0be89d8fe1cc5616091e0ceb47abfd55f
Author: Gary Kotton <email address hidden>
Date: Thu Mar 21 06:11:36 2013 +0000

    Locking edge case when lock_path does not exist

    Fixes bug 1158179

    In the case that the lock_path does not exist and there is a contested
    resource then the process that was waiting on the lock will not
    be locking due to the fact that the directory was deleted.

    Change-Id: I75d720d4df499e85386d3e2cc86b927b017e12ac

Changed in oslo:
status: In Progress → Fix Committed
John Griffith (john-griffith)
Changed in cinder:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo-incubator (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/25233

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/25234

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (milestone-proposed)

Reviewed: https://review.openstack.org/25234
Committed: http://github.com/openstack/quantum/commit/dd5c549088fe03b359d062f9effee98754027698
Submitter: Jenkins
Branch: milestone-proposed

commit dd5c549088fe03b359d062f9effee98754027698
Author: Gary Kotton <email address hidden>
Date: Sun Mar 24 07:36:51 2013 +0000

    Update oslo lockutils

    Fixes bug 1158179

    Change-Id: I9b8f5768480a0266dae10aeac15408e34e7d46da

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/25260

Changed in quantum:
status: New → In Progress
Revision history for this message
Mark McLoughlin (markmc) wrote :

Fixed in nova for havana by https://review.openstack.org/25167

Changed in nova:
assignee: nobody → Russell Bryant (russellb)
status: Confirmed → Fix Committed
Mark McLoughlin (markmc)
tags: removed: grizzly-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo-incubator (stable/grizzly)

Reviewed: https://review.openstack.org/25233
Committed: http://github.com/openstack/oslo-incubator/commit/3cb71ffeaabf8f30e761bb498142a3c56b4fd640
Submitter: Jenkins
Branch: stable/grizzly

commit 3cb71ffeaabf8f30e761bb498142a3c56b4fd640
Author: Gary Kotton <email address hidden>
Date: Thu Mar 21 06:11:36 2013 +0000

    Locking edge case when lock_path does not exist

    Fixes bug 1158179

    In the case that the lock_path does not exist and there is a contested
    resource then the process that was waiting on the lock will not
    be locking due to the fact that the directory was deleted.

    Change-Id: I75d720d4df499e85386d3e2cc86b927b017e12ac

Thierry Carrez (ttx)
tags: added: grizzly-rc-potential
Russell Bryant (russellb)
Changed in nova:
milestone: none → grizzly-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/25277

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/25260
Committed: http://github.com/openstack/quantum/commit/6891a4d976eeef094d1e4cb3f9552a31e843ba61
Submitter: Jenkins
Branch: master

commit 6891a4d976eeef094d1e4cb3f9552a31e843ba61
Author: Gary Kotton <email address hidden>
Date: Mon Mar 25 05:59:32 2013 +0000

    Update latest OSLO

    Includes fix for bug 1158179

    Change-Id: Ifd8cde2903dcd013903e95a30c2ed422e89bcd0f

Changed in quantum:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (milestone-proposed)

Reviewed: https://review.openstack.org/25277
Committed: http://github.com/openstack/nova/commit/817bdebb7cda941182d50d6edd14b56c2aec0ded
Submitter: Jenkins
Branch: milestone-proposed

commit 817bdebb7cda941182d50d6edd14b56c2aec0ded
Author: Russell Bryant <email address hidden>
Date: Mon Mar 25 10:37:02 2013 -0400

    Sync lockutils from oslo-incubator stable/grizzly.

    Changes include:

    3cb71ff Locking edge case when lock_path does not exist
    21925b6 Fix locking issues in Windows
    547ab34 Fix Copyright Headers - Rename LLC to Foundation

    Fix bug 1158179.

    Change-Id: I8231a6d37b70c36ba2ce245407b02698faa55aaf

Changed in nova:
status: Fix Committed → Fix Released
dan wendlandt (danwent)
Changed in quantum:
status: Fix Committed → Fix Released
John Griffith (john-griffith)
Changed in cinder:
milestone: none → grizzly-rc3
Thierry Carrez (ttx)
Changed in cinder:
importance: Undecided → High
assignee: nobody → John Griffith (john-griffith)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/25406

Changed in cinder:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/25411

Thierry Carrez (ttx)
no longer affects: nova/grizzly
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/25406
Committed: http://github.com/openstack/cinder/commit/649e8926cf6a6ee1cc01a34e6f718e0996feb930
Submitter: Jenkins
Branch: master

commit 649e8926cf6a6ee1cc01a34e6f718e0996feb930
Author: John Griffith <email address hidden>
Date: Tue Mar 26 10:19:47 2013 -0600

    Sync lockutils from oslo-incubator stable/grizzly.

    Changes include:

    3cb71ff Locking edge case when lock_path does not exist
    21925b6 Fix locking issues in Windows
    547ab34 Fix Copyright Headers - Rename LLC to Foundation

    Fix bug 1158179.

    Change-Id: I0d5fb58bef593233068accfcea0dff9fa05f61ef

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (milestone-proposed)

Reviewed: https://review.openstack.org/25411
Committed: http://github.com/openstack/cinder/commit/75af3f7669938e799df28adce228f0a5a9d7e109
Submitter: Jenkins
Branch: milestone-proposed

commit 75af3f7669938e799df28adce228f0a5a9d7e109
Author: John Griffith <email address hidden>
Date: Tue Mar 26 10:19:47 2013 -0600

    Sync lockutils from oslo-incubator stable/grizzly.

    Changes include:

    3cb71ff Locking edge case when lock_path does not exist
    21925b6 Fix locking issues in Windows
    547ab34 Fix Copyright Headers - Rename LLC to Foundation

    Fix bug 1158179.

    Change-Id: I0d5fb58bef593233068accfcea0dff9fa05f61ef
    (cherry picked from commit 649e8926cf6a6ee1cc01a34e6f718e0996feb930)

Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
tags: removed: grizzly-rc-potential
Thierry Carrez (ttx)
Changed in quantum:
milestone: grizzly-rc2 → 2013.1
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-rc2 → 2013.1
Thierry Carrez (ttx)
Changed in cinder:
milestone: grizzly-rc3 → 2013.1
Revision history for this message
Alan Pevec (apevec) wrote :

Cinder stable/folsom review https://review.openstack.org/#/c/23914/ was not approved.

no longer affects: nova/folsom
Zhongyue Luo (zyluo)
description: updated
description: updated
Thierry Carrez (ttx)
Changed in oslo:
milestone: none → havana-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in oslo:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.