[ffe] unplugging an external monitor from laptop results in corrupted screen. Logging out fixes it.

Can you please attach a photo of the screen corruption?

Plugging the monitor back in now returns the screen to normal.
I'm attaching video of the corruption.

Fixed by upstream

commit 4878cae22a2405b6d33318e2dc99a9c1367fee44
Author: Ville Syrjälä <email address hidden>
Date: Mon Feb 18 19:08:48 2013 +0200

    drm/i915: Really wait for pending flips when panning

Hitting this bug.
Building a test package with commit from here:
http://cgit.freedesktop.org/~danvet/drm-intel/commit/?h=drm-intel-next&id=4878cae22a2405b6d33318e2dc99a9c1367fee44

On Tue, Mar 26, 2013 at 12:16:54PM -0000, Chris J Arges wrote:
> Hitting this bug.
> Building a test package with commit from here:
> http://cgit.freedesktop.org/~danvet/drm-intel/commit/?h=drm-intel-next&id=4878cae22a2405b6d33318e2dc99a9c1367fee44

Chris, if you can make that test package available I'd be happy to give it a
whirl.

Fwiw, I seem to be able to work around this by locking my screen first, and then unplugging it. Need to unlock afterwards, obviously, but thought it might save people a few mins of resetting things...

Tom Haddon: This does not work for me. I lock screen (ctrl-alt-l), unplug monitor. Then screen corruption is visible. I put in password, and get back to corrupted desktop on one screen.
Plugging in the external monitor then eliminates the corruption.

With external monitor plugged in, if I use the monitors control to turn off the external (rather than unplugging it), I get the same bug.

On Tue, Apr 02, 2013 at 05:53:51PM -0000, Christopher Barrington-Leigh wrote:
> With external monitor plugged in, if I use the monitors control to turn
> off the external (rather than unplugging it), I get the same bug.

I would add that the problem for me is not specific to changing the monitor
outputs. Changing the resolution of the LVDS1 output (as I've been doing
lately to try to develop a bugfix for compiz window placement) also triggers
the same kind of corruption.

Test build with patch is here:
http://people.canonical.com/~arges/lp1157678/

I've tested this build with the following on my Thinkpad T420:
1) Plugged in VGA cable to external monitor, waited monitors to set proper resolution.
2) Unplugged VGA cable, waited for LVDS1 to be set to proper resolution.
3) Repeated 1/2 a few times.
4) Suspended and resumed.
5) Repeated 1/2 a few times.
This works for me. If somebody else can confirm, I'll get this applied to raring, and SRUed to other series.

$ uname -a
Linux virgil 3.8.0-16-generic #26~lp1157678v20130402 SMP Tue Apr 2 12:55:49
CDT 2013 x86_64 x86_64 x86_64 GNU/Linux

I'm sorry to report that this doesn't fix the problem for me. I still usually see corruption as in the attached photo on one or the other of the outputs when I change the monitor configuration. sometimes, cycling through the configs clears it; other times it does not.

(please be advised if you are viewing the provided image in a browser that it may be rotated 180 degrees. Phone cameras are not designed for left-handed people, and not all image viewers are smart enough to cope with the exif metadata. :P)

If you could double check the kernel you tested had the patch, that would be fantastic. And you can install drm-intel-nightly from ppa:mainline to confirm the bug is fixed somewhere between 3.8 and now.

This bug has been reported on the Ubuntu laptop testing tracker.

A list of all reports related to this bug can be found here:
http://laptop.qa.ubuntu.com/qatracker/reports/bugs/1157678

Chris, I have no way to double-check that the kernel I tested had the patch, I only have the binary build that Chris Arges posted so I have to take his word for it.

I can certainly give the drm-intel-nightly kernel a try. Can you confirm that http://kernel.ubuntu.com/~kernel-ppa/mainline/drm-intel-nightly/ is the kernel you mean?

@vorlon
Yes, the binary build I provided had 4878cae22a2405b6d33318e2dc99a9c1367fee44 cleanly cherry picked.
From the uname you had the kernel I built installed.

@ickle
Would there be other patches that would also be required, or should be included to be backported to 3.8?

I've tested the mainline kernel back on 3/26, and it didn't resolve my issues for me. But that particular mainline build didn't include the above fix which I had to pull from the drm-intel git tree.

I'll try the drm intel nightly as well.

There were quite a few pageflip related fixes, the one I picked out was the one that found by my reverse bisection.

@vorlon,
Not sure what exactly changed but I have been unable to reproduce with 3.8.0-17.27. But this really doesn't make sense because the above patch was not applied to this release.

I plugged in an external monitor and unplugged it 10 times, and suspended and repeated and was unable to get the original graphic glitching. I'll continue to check this.

@ickle, I've just reproduced the issue with the drm-intel-next build from http://kernel.ubuntu.com/~kernel-ppa/mainline/drm-intel-nightly/2013-04-06-raring/:

$ uname -a
Linux virgil 3.9.0-994-generic #201304060409 SMP Sat Apr 6 08:10:44 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux
$

So this problem doesn't appear to be fixed.

I can reproduce this issue using:
    xrandr --output DP1 --auto --primary --output LVDS1 --off
With 3.8.0-17-generic and drm-intel-next (3.9.0-997) after plugging in an external monitor.

Perhaps this is a different issue than the one reported on freedesktop.

FIled upstream bug here:
https://bugs.freedesktop.org/show_bug.cgi?id=63383

As Chris Arges and I are both still seeing this symptom with all the kernels, and Christopher (the original bug submitter) hasn't commented on whether he still sees the problem, I'm going to un-dupe bug #1155838 from this one.

Yes, I still see it on the latest main-stream updates for 13.04. I haven't tried a special PPA.
Thanks,
c

Building and installing latest xf86-video-intel.git with HEAD: http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/commit/?id=f0b6ae2cfb811a8c234634c878800ca1fb95703f

Seems to resolve the issue, I've tested the original issue of unplugging and plugging in an external monitor, suspending and resuming, and also the xrandr trigger. So far no screen corruption.

Test fix with 9dae6f9f1f169c228929185a8bd94e82afe92574 backported here:
http://people.canonical.com/~arges/lp1157678.1/

This patch is a cherry pick of 9dae6f9f1f169c228929185a8bd94e82afe92574.
There was only a minor conflict and it was fixed. To build this, you must have also resolved the issue with including valgrind.h.

The attachment "0001-sna-Flush-the-scanout-cache-after-resizing-the-displ.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

I happened to reproduce this myself while testing another bug, so if you don't mind I'll just steal the bug :)

committed the patch to my local git tree, will push later today.

The original patch is large due to some code refactoring. Here is a more minimal patch that just shows the functional changes without the refactoring.

You can see the patch:
  a) Adds a routine to check the scanout size
  b) Adds code to cleanup the large_inactive and scanout lists in a couple places
  c) Loops the check for pending events

I just accepted xserver-xorg-video-intel, but put a britney block in place for it. It looks like a good, but not essential for release fix. If there's no opportunity to copy it in, then it can be an SRU.

Now that the package is built in raring-proposed, could someone who is experiencing the problem verify that the update solves the problem (like we would do for an SRU)?

I've installed the package and it fixes the issue! I used the original xrandr command I used to reproduce the issue as well as plugged in and out the external VGA connector. I also suspended my laptop and repeated the tests.

One note, the changelog should say [ Chris Wilson], instead of my name since he's the author of the patch. I merly produced the initial backport, and Bryce cleaned up and produced the final backport.

Thanks for verifying. I've unblocked it so it will go into raring.

This bug was fixed in the package xserver-xorg-video-intel - 2:2.21.6-0ubuntu4

---------------
xserver-xorg-video-intel (2:2.21.6-0ubuntu4) raring-proposed; urgency=low

  [Chris Arges]
  * Add sna-flush-scanout-cache-after-resizing.patch: Flush the scanout
    cache after resizing the display. Fixes a problem that occurs
    e.g. when unplugging an external display, suspend/resume, etc. by
    ensuring the scanout cache is properly sized.
    (LP: #1157678)
 -- Bryce Harrington <email address hidden> Fri, 19 Apr 2013 11:12:14 -0700

It arrived in raring updates and works on my system. Thank you.

> It arrived in raring updates and works on my system. Thank you.

Same here, thanks!

I confirm that the patch fixes the issue for me. Thanks!