widelands

Windowed graphics resolution change does not resize window

Bug #1096651 reported by Mark Scott
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
High
Mark Scott
widelands build18-rc1

Bug Description

In build17, if you change the windowed graphics resolution in the Options menu, e.g. from 800x600x32 to 1024x768x32, the size of the window changes on pressing Apply.

In trunk, this does not happen - the surface appears to change size but the OS window does not. This is more obvious when going from a larger to a smaller resolution - the right and the bottom of the window remain showing the (larger) options menu, but the smaller new surface shows main menu.

Interestingly, the new window size does take effect when the game starts (e.g. play tutorial).

Tags: regression

Related branches

lp:~mxsscott/widelands/windowed-graphics
SirVer: Approve
Diff: 414 lines (+138/-75)
8 files modified
src/sound/sound_handler.cc (+2/-2)
src/ui_fsmenu/base.cc (+2/-2)
src/ui_fsmenu/options.cc (+76/-24)
src/ui_fsmenu/options.h (+19/-6)
src/wlapplication.cc (+25/-4)
src/wlapplication.h (+12/-2)
src/wui/interactive_base.cc (+2/-32)
src/wui/interactive_base.h (+0/-3)
Revision history for this message
Hans Joachim Desserud (hjd) wrote :

I see the same behavior here on Ubuntu. Works fine with build 17 compiled on the same system.

Changed in widelands:
importance: Undecided → High
milestone: none → build18-rc1
status: New → Confirmed
tags: added: regression
Mark Scott (mxsscott)
Changed in widelands:
assignee: nobody → Mark Scott (mxsscott)
status: Confirmed → In Progress
Revision history for this message
Mark Scott (mxsscott) wrote :

There's a few sub-bugs here...

   1. The menus were basing their surface sizes on the values stored in the user's options, which got updated immediately.
   2. The graphics system (g_gr; Graphic) was not being reinitialized on exit from the options submenu, so the window size was not changed.
   3. The graphics system was being reinitialized halfway through game startup (when Interactive_Base was created). This caused funky texture / graphic issues possibly related to the image cache changes in r6446 - there is a note against init_graphics() to say don't call it whilst UI elements are active.

Revision history for this message
Mark Scott (mxsscott) wrote :
Revision history for this message
Mark Scott (mxsscott) wrote :

Fix merged to trunk.

Changed in widelands:
status: In Progress → Fix Committed
Revision history for this message
SirVer (sirver) wrote :

Released in build-18 rc1.

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.