Strings not extracted for translation because of single quotation marks

Bug #1065246 reported by Gabor Kelemen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Translations
Fix Released
High
Unassigned
WebApps: Applications Data
Fix Released
Undecided
Unassigned
webapps-applications (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

There are some .js files which contain strings marked for translation, but the strings are not extracted into the pot file.

This is because gettext does not support JavaScript, and thus .js files listed in POTFILES.in will be considered as being the default syntax, which is C. However in C, only strings between double quotation marks are considered for extraction into the pot template, the ones between single quotation marks are not. The affected files are currently:

gabor@gabor-laptop:~/src/launchpad/webapps-applications$ grep -r \_\(\' *default-apps/Amazon/Amazon.user.js: addAction(_('Basket'), 'gp/cart/view.html');
default-apps/Amazon/Amazon.user.js: addAction(_('Wishlist'), 'gp/registry/wishlist/');
default-apps/Amazon/Amazon.user.js: addAction(_('Orders'), 'gp/css/history/orders/view.html');
default-apps/Amazon/Amazon.user.js: addAction(_('Manage your Kindle'), 'gp/digital/fiona/manage');
src/Twitter/Twitter.user.js: title = _('Tweets');
src/Amazon/Amazon.user.js: addAction(_('Basket'), 'gp/cart/view.html');
src/Amazon/Amazon.user.js: addAction(_('Wishlist'), 'gp/registry/wishlist/');
src/Amazon/Amazon.user.js: addAction(_('Orders'), 'gp/css/history/orders/view.html');
src/Amazon/Amazon.user.js: addAction(_('Manage your Kindle'), 'gp/digital/fiona/manage');

Related branches

Gabor Kelemen (kelemeng)
visibility: private → public
Changed in ubuntu-translations:
status: New → Triaged
importance: Undecided → High
Maxim Ermilov (zaspire)
Changed in webapps-applications:
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webapps-applications - 2.4.7-0ubuntu4

---------------
webapps-applications (2.4.7-0ubuntu4) quantal; urgency=low

  * debian/patches/bzr_extract_strings.patch:
     - Cherry-pick an upstream fix for strings not extracted for translation
     because of single quotation marks (LP: #1065246)
 -- Didier Roche <email address hidden> Thu, 11 Oct 2012 10:21:26 +0200

Changed in webapps-applications (Ubuntu):
status: New → Fix Released
David Planella (dpm)
Changed in ubuntu-translations:
status: Triaged → Fix Released
Maxim Ermilov (zaspire)
Changed in webapps-applications:
status: Fix Committed → Fix Released
no longer affects: webapps-applications (Ubuntu Raring)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.