Stray semicolon in datetime-prefs
Bug #1064546 reported by
Charles Kerr
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Indicator Date and Time |
Fix Released
|
Medium
|
Charles Kerr | ||
| indicator-datetime (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
Coverity found the stray semicolon in line 311 here in datetime-prefs.c:
311 if (priv->
312 priv->tz_
313 g_dbus_proxy_call (priv->proxy, "GetTimezone", NULL, G_DBUS_
314 priv->tz_
315 }
316}
Looks like this was introduced in http://
It looks to me like the downside of this extra semicolon is that the crash in bug #942450 could still be triggered in 12.04 and in indicator-datetime 12.10.2
Related branches
lp:~charlesk/indicator-datetime/lp-1064546
- Lars Karlitski (community): Approve
- jenkins (community): Approve (continuous-integration)
-
Diff: 12 lines (+1/-1)1 file modifiedsrc/datetime-prefs.c (+1/-1)
lp:~cyphermox/indicator-datetime/bootstrap
- Charles Kerr (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 15 lines (+6/-0)1 file modifieddebian/changelog (+6/-0)
| Changed in indicator-datetime: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in indicator-datetime (Ubuntu): | |
| status: | New → Fix Released |
| Changed in indicator-datetime: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package indicator-datetime - 12.10.3daily12.
---------------
indicator-datetime (12.10.
[ Mathieu Trudel-Lapierre ]
* Automatic snapshot from revision 197 (bootstrap):
- Add scaffolding for Google Tests. (LP: #985060)
- Add "check-news" to our AM_INIT_AUTOMAKE() call. (LP: #1075753)
- Don't use geoclue until the user clicks the "Show time in auto-detected
location" checkbox. (LP: #1074999)
- Remove stray semicolon found by Coverity. (LP: #1064546)
* debian/control:
- Update to follow style like other indicator packages: use trailing commas
at the end of lists.
- Reorganize Build-Depends for clarity.
- Drop Build-Depends on cdbs, bump debhelper to (>= 9).
- Update Vcs-Bzr and Vcs-Browser, add a notice for uploaders.
- Add gnome-common to Build-Depends.
- Add libxorg-gtest-dev, libgtest-dev to Build-Depends.
* debian/compat: bump compat level to 9.
* debian/rules:
- Switch to using the dh sequencer instead of cdbs rules, adjust targets
accordingly.
- Override dh_autoreconf to make it use autogen.sh from upstream.
[ Didier Roche ]
* debian/copyright:
- Update the copyright
[ Mathieu Trudel-Lapierre ]
* Don't use geoclue if "show-auto-
(LP: #1074999)
* Add check-news to indicators' AM_INIT_AUTOMAKE rules (LP: #1075753)
* Add Google Test to projects lacking test suites (LP: #985060)
* Stray semicolon in datetime-prefs (LP: #1064546)
[ Automatic PS uploader ]
* Automatic snapshot from revision 199
-- Automatic PS uploader <email address hidden> Fri, 23 Nov 2012 07:39:58 +0000