AsyncPreview doesn't allow null preview
Bug #1060281 reported by
Paweł Stołowski
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| libunity |
Fix Released
|
High
|
Paweł Stołowski | ||
| libunity (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
Bug Description
AsyncPreview doesn't allow null preview argument for preview_ready signal, resulting in critical errors and no preview at all.
Current code of async preview handling in libunity was designed to return GenericPreview in such case, but it's never reached because of wrong signature of preview_ready.
This behaviour can be reproduced with current (as of 2nd Oct) stock Quantal, when previewing u1ms shopping lens items.
Related branches
lp:~stolowski/libunity/async-preview-with-null
- Michal Hruby (community): Approve
-
Diff: 88 lines (+59/-1)2 files modifiedsrc/unity-previews.vala (+1/-1)
test/vala/test-lens.vala (+58/-0)
| Changed in libunity: | |
| importance: | Critical → High |
| status: | Confirmed → In Progress |
| Changed in libunity (Ubuntu): | |
| status: | New → In Progress |
| importance: | Undecided → High |
| Changed in libunity: | |
| status: | In Progress → Fix Committed |
| milestone: | none → 6.8.0 |
| milestone: | 6.8.0 → none |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in libunity (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in libunity: | |
| status: | Fix Committed → Fix Released |
| no longer affects: | libunity (Ubuntu Quantal) |
To post a comment you must log in.
This bug was fixed in the package libunity - 6.8.0-0ubuntu1
---------------
libunity (6.8.0-0ubuntu1) quantal-proposed; urgency=low
[ Didier Roche ]
* Install the new schema file
* add intltool as a build-dep
[ Dmitry Shachnev ]
* Make libunity9 depend on unity-common >= 6.0.0-0ubuntu3 (LP: #1055019).
[ Timo Jyrinki ]
* New upstream release.
- Converts white space to underscores when trying to export the mpris
bus (LP: #1031933)
- Added size hint to AnnotatedIcon (LP: #1052513)
- Add remote search disabling option support to libunity for lenses to
consume it (LP: #1054746)
- Make sender wrap the title property and set the subtitle in the
constructor. (LP: #1058198)
- Allow null preview argument in preview_ready signal by declaring it
with "?" (LP: #1060281)
* debian/
- update symbols to include the new APIs
-- Timo Jyrinki <email address hidden> Wed, 03 Oct 2012 09:22:42 +0300