OpenStack Compute (nova)

All subprocess.Popen calls should go through common function

Bug #1053382 reported by Thierry Carrez on 2012-09-20

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Compute (nova)	Fix Released	Low	Joshua Hesketh	OpenStack Compute (nova) 2013.2 "havana"

Bug Description

Looks like while I was looking the other way, more rogue subprocess.Popen calls got introduced in Nova:

nova/virt/baremetal/tilera.py
nova/virt/hyperv/volumeutils.py
plugins/xenserver/networking/etc/xensource/scripts/novalib.py
plugins/xenserver/xenapi/etc/xapi.d/plugins/xenhost
plugins/xenserver/xenapi/etc/xapi.d/plugins/xenstore.py
plugins/xenserver/xenapi/etc/xapi.d/plugins/utils.py

Those should be checked and make use of nova.utils.execute where appropriate, to benefit from all the patches we push there (like bug 1053364)

Michael Still (mikal) on 2012-10-16

Changed in nova:
importance:	Wishlist → Low

OpenStack Infra (hudson-openstack) on 2013-09-04

Changed in nova:
assignee:	nobody → Joshua Hesketh (joshua.hesketh)
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-09-05: Fix merged to nova (master)

Reviewed: https://review.openstack.org/44799
Committed: http://github.com/openstack/nova/commit/4c2f36bfe006cb0ef89ca7a706223f30488a182e
Submitter: Jenkins
Branch: master

commit 4c2f36bfe006cb0ef89ca7a706223f30488a182e
Author: Joshua Hesketh <email address hidden>
Date: Tue Sep 3 16:00:59 2013 +1000

Use utils.execute instead of subprocess

    Removes rogue subprocess.Popen calls to make better use of
    nova.utils.execute where appropriate to benefit from the
    patches pushed into oslo.

Fixes bug 1053382

Change-Id: Iaee5379edd51f215a51d55263196dd6c0d2de0c3