keystoneclient sends a request body of 'null' on PUT requests
Bug #1050097 reported by
Dolph Mathews
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
python-keystoneclient |
Fix Released
|
Medium
|
Joseph Heck |
Bug Description
Instead of submitting an empty request body on PUT requests as expected by the API, the client unexpectedly:
- Encodes a body=None value as json.dumps(None) --> 'null'
- Includes a non-zero Content-Length (which is accurate here, but unexpected)
- Includes 'application/json' as the Content-Type (which is also accurate here, but again unexpected)
This was discovered after fixing unit tests in bug 1050091, which actually asserted this client-side behavior.
tags: | added: blueprint ldap-ad |
Changed in keystone: | |
status: | New → Triaged |
importance: | Undecided → Medium |
tags: | removed: blueprint ldap-ad |
Changed in python-keystoneclient: | |
status: | New → Triaged |
importance: | Undecided → Medium |
no longer affects: | keystone |
Changed in python-keystoneclient: | |
milestone: | none → 0.2.0 |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/12909 github. com/openstack/ python- keystoneclient/ commit/ 59917278d7a2e37 60d6229f874b2a9 53bf2b28cc
Committed: http://
Submitter: Jenkins
Branch: master
commit 59917278d7a2e37 60d6229f874b2a9 53bf2b28cc
Author: Dolph Mathews <email address hidden>
Date: Wed Sep 12 17:34:09 2012 -0500
Fixed httplib2 mocking (bug 1050091, bug 1050097)
- 204 No Content should be mocked with empty response bodies
- Content-Type headers should not be mocked with empty response bodies
- httplib2 would never return None as a response body
- The Identity API never expects a req/resp body with a string value of "null"
Change-Id: Ie22e8e52885732 68165ed06049978 195955f8ca6