OpenStack Compute (nova)

Live migrate task_state race condition

Bug #1049533 reported by Jian Wen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Jian Wen
OpenStack Compute (nova) 2012.2 "folsom"

Bug Description

Update task_states.MIGRATING may overwrite the other task_state.

Jian Wen (wenjianhn)
Changed in nova:
assignee: nobody → Sina Web Service Dev (sws)
Revision history for this message
Jian Wen (wenjianhn) wrote :

Related bug:
task_state may be overwritten in race condition
https://bugs.launchpad.net/nova/+bug/1037372

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/12859

Changed in nova:
assignee: Sina Web Service Dev (sws) → Jian Wen (wenjianhn)
status: New → In Progress
Thierry Carrez (ttx)
Changed in nova:
importance: Undecided → Medium
Vish Ishaya (vishvananda)
Changed in nova:
milestone: none → folsom-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/12859
Committed: http://github.com/openstack/nova/commit/a3bdc1624fd557e0699acb049b1ca0c1ef894c2f
Submitter: Jenkins
Branch: master

commit a3bdc1624fd557e0699acb049b1ca0c1ef894c2f
Author: Jian Wen <email address hidden>
Date: Wed Sep 12 17:45:03 2012 +0800

    Avoid live migrate overwriting the other task_state

    As commit 4082c8375a6ae7e7e67c7ad2e263be2d5fc3dd1f says,
    one ordinary task is running, so that task_state is set. The
    live_migrate task is accepted at API, and will change task_state to
    MIGRATING. However the first task may continue to update task_state or
    set it to None as it finishes.

    This patch avoids it by updating task_state in compute.api.live_migrate
    level with expected_task_state=None.

    Add test case for compute.api.live_migrate.

    Fixes bug 1049533

    Change-Id: Ida8cef4797de421a7e356c9f5e882fe926535639

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-rc1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.