Qt's non-native file/directory choosing panel looks wrong on darwin
Bug #1044201 reported by
Mike McCracken
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| Ubuntu One Control Panel | Status tracked in Trunk | |||||
| Stable-4-2 |
Fix Released
|
Medium
|
Mike McCracken | |||
| Trunk |
Fix Released
|
Medium
|
Mike McCracken | |||
Bug Description
The "add a folder" button now brings up a non-native file chooser dialog because of the fix for bug 1040905.
This looks particularly out of place on OS X, where even apps with "non-standard" UI use the same uniform file dialogs.
Also it's unstyled and doesn't match the rest of the app.
However, Qt seems likely not to include a fix for the Qt bug we are working around until Qt5, so we should investigate possibly using PyObjC or a tiny C extension.
Related branches
lp:~mikemc/ubuntuone-control-panel/fix-native-dialog
- dobey (community): Approve
- Michał Karnicki (community): Approve
-
Diff: 282 lines (+116/-48)6 files modifiedubuntuone/controlpanel/gui/qt/addfolder.py (+12/-4)
ubuntuone/controlpanel/gui/qt/main/__init__.py (+2/-1)
ubuntuone/controlpanel/gui/qt/main/darwin.py (+21/-0)
ubuntuone/controlpanel/gui/qt/main/tests/test_darwin.py (+40/-0)
ubuntuone/controlpanel/gui/qt/tests/__init__.py (+0/-40)
ubuntuone/controlpanel/gui/qt/tests/test_addfolder.py (+41/-3)
| Changed in ubuntuone-control-panel: | |
| status: | Confirmed → Fix Committed |
To post a comment you must log in.
