lp:~mikemc/ubuntuone-control-panel/fix-native-dialog

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:ubuntuone-control-panel at revision 392

dobey (community): Approve on 2013-01-11

Michał Karnicki (community): Approve on 2012-12-21

Diff: 282 lines (+116/-48)

6 files modified

ubuntuone/controlpanel/gui/qt/addfolder.py (+12/-4)
ubuntuone/controlpanel/gui/qt/main/__init__.py (+2/-1)
ubuntuone/controlpanel/gui/qt/main/darwin.py (+21/-0)
ubuntuone/controlpanel/gui/qt/main/tests/test_darwin.py (+40/-0)
ubuntuone/controlpanel/gui/qt/tests/__init__.py (+0/-40)
ubuntuone/controlpanel/gui/qt/tests/test_addfolder.py (+41/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1044201: Qt's non-native file/directory choosing panel looks wrong on darwin

Medium

Fix Released

Link a bug report

Related blueprints

396. By Mike McCracken on 2013-01-11

Strip pylint comments from moved FakedFileDialog

395. By Mike McCracken on 2012-12-21

re-add test cleanup that crashes test suite on darwin. Commenting it out is a hack that shouldn't end up in trunk, probably.

394. By Mike McCracken on 2012-12-21

raise after using file dialog, necessary on darwin because dialog is shown by a separate hidden process

393. By Mike McCracken on 2012-12-21

tag bug

392. By Mike McCracken on 2012-12-21

Change darwin file dialog function into class method to match QFileDialog and make testing simpler. Move patches for QFileDialog into test_addfolder so we can patch addfolder.FileDialog cleanly.

391. By Mike McCracken on 2012-12-20

Quash dangling debug print.

390. By Mike McCracken on 2012-12-20

Add darwin-specific applescript hack to show native open dialog instead of ugly qt thing.

389. By Mike McCracken on 2012-12-13

- Add u1 folder to OS X Finder favorites sidebar on first launch.

388. By Brian Curtin on 2012-12-12

- Add common updater script for mac and windows. (LP: #1087262)

387. By Mike McCracken on 2012-12-04

- Trivial fix to make a test in test_folders actually run.

The test wasn't using the inlineCallbacks decorator, so it never returned from the first yield, but this wasn't treated as an error, the test passed.

Tested on mac/win/ubuntu 12.10