Don't think there's any need for a license header in doc/source/conf.py

Bug #1039861 reported by Ray Chen
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Object Storage (swift)
Fix Released
Undecided
Yee

Bug Description

I don't think there's any need for a license header in doc/source/conf.py in Swift.

Revision history for this message
Yee (mail-zhang-yee) wrote :

Let me address this, see if git setup is OK or not.

Changed in swift:
assignee: nobody → Yee (mail-zhang-yee)
Yee (mail-zhang-yee)
Changed in swift:
assignee: Yee (mail-zhang-yee) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to swift (master)

Fix proposed to branch: master
Review: https://review.openstack.org/15828

Changed in swift:
assignee: nobody → Yee (mail-zhang-yee)
status: New → In Progress
Revision history for this message
gholt (gholt) wrote :

This was already tried with https://review.openstack.org/12243

Can someone explain why it's important to remove such a license? If I get a good reason I'd be happy to +2 this, but so far all I've seen is "I don't think it should be there and I don't like it."

Revision history for this message
Yee (mail-zhang-yee) wrote :

Hi gholt, i think it's better to make consistent among Openstack projects, nova/keystone/cinder and so on did not maintain license header in doc/source/conf.py

Revision history for this message
gholt (gholt) wrote :

Thanks for the explanation, Yee.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift (master)

Reviewed: https://review.openstack.org/15828
Committed: http://github.com/openstack/swift/commit/53ab2e150df92f6780819b7e66eb4c71688bd154
Submitter: Jenkins
Branch: master

commit 53ab2e150df92f6780819b7e66eb4c71688bd154
Author: Yee <email address hidden>
Date: Sun Nov 11 00:15:39 2012 -0800

    fix bug1039861, remove license header in doc/source/conf.py.

    Change-Id: Iab43ac342faf3722ccab1ed034f08752dbbfaae1

Changed in swift:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in swift:
milestone: none → 1.7.6
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.