PEP8 version differs between test_requires and tox.ini

Bug #1037303 reported by Maru Newby
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Dolph Mathews

Bug Description

tox.ini specifies pep8==1.1, but test_requires specifies 1.3.3. This means that a tox pep8 run may (and currently does) return different results than a run_tests.sh pep8 run.

Presumably the version in tox.ini should be updated to match test_requires?

Revision history for this message
Joseph Heck (heckj) wrote :

Until we do all the pep8 1.3 cleanup (mostly indent related work), the tox.ini shouldn't be updated. It's not adding any functionality, so we've deferred this work from earlier.

Changed in keystone:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Maru Newby (maru) wrote :

Joe: What about downgrading the version in test-requires to ensure consistent results between pep8 run through test-requires and tox?

Dolph Mathews (dolph)
Changed in keystone:
assignee: nobody → Dolph Mathews (dolph)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/12181

Changed in keystone:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/12181
Committed: http://github.com/openstack/keystone/commit/5446577a643bb54881c3ccc3fa458c441313cc94
Submitter: Jenkins
Branch: master

commit 5446577a643bb54881c3ccc3fa458c441313cc94
Author: Dolph Mathews <email address hidden>
Date: Thu Aug 30 03:38:14 2012 -0500

    Upgrade PEP8 to 1.3.3 (bug 1037303)

    Change-Id: I83aa851cec80652888faf3fe29d8b4904f8b4f63

Changed in keystone:
status: In Progress → Fix Committed
Joseph Heck (heckj)
Changed in keystone:
milestone: none → folsom-rc1
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: folsom-rc1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.