psensor should show a proper Celsius degree symbol

Bug #1021900 reported by Bence Lukács
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
psensor
Fix Released
Undecided
Unassigned
psensor (Ubuntu)
Fix Released
Low
Unassigned
Precise
Fix Released
Low
Unassigned

Bug Description

In Ubuntu 12.04 the Psensor shows the celsius degree badly. Both in the main window and in the indicator. For example if the temperature is 55 celsius degree it should be showed like this: 55°C not like this: 55 C, because it is very ugly.
I use Psensor 0.6.2.16

SRU information:

[Impact]
The degree Celcius symbol is missing.
Even if it is a real bug, it does not block any psensor feature usage, it is only cosmetic.
It will be nice to have it fixed in precise which is a LTS but should be handled with
a very very low priority. SRU team members are certainly more useful patch to check and
upload than this one.

The fix is trivial, it simply adds the celcius degree sign before the 'C'.

[Test Case]
Here is a screenshot showing the bug: https://bugs.launchpad.net/psensor/+bug/1021900/+attachment/3225364/+files/LP1021900_KO.png
The missing degree sign is emphasized in the red circles

To reproduce:
 - 1 - ubuntu precise must be installed in a real computer and not in a virtual machine.
       VM does not allow to retrieve thermal sensors of the computer. The hardware
       must have at least one thermal sensor supported by lmsensor.
 - 2 - install psensor
 - 3 - starts the sensor detection script and follow its instruction: sudo sensors-detect
 - 4 - reboot the computer to ensure that the needed kernel module are loaded
 - 5 - starts 'psensor', wait a couple of seconds until the sensors measures are retrieved
 - 6 - check that all celcius units displayed in the main window have the degree sign
 - 7 - open the psensor application indicator and checks the degree sign

You can see the correct display in this screenshot:
https://bugs.launchpad.net/psensor/+bug/1021900/+attachment/3225793/+files/LP1021900_OK.png

A unit test has been added for this bug in the maintream dev branch, but it involves modification of the build files that I am not yet confortable with. So, I believe it is safer to do a manual check than port the unit test to the patch for this fix:
http://wpitchoune.net/svnpub/psensor/trunk/tests/test_psensor_type_to_unit_str.c
and http://wpitchoune.net/svnpub/psensor/trunk/tests/test_psensor_value_to_str.c

[Regression Potential]

The fix is trivial, the unit string are not dynamicaly allocated nor translatable, I don't expect any regression.

The fix has been commited upstream in mainstream dev branch few months ago and nobody
raised a regression bug. Mainstream dev branch has been tested on both Ubuntu and Debian.

The only probleme with this fix that I can imagine is that the used default font does not have the glyph corresponding to the degree sign. It might lead to a corrupted display but most used font certainly has the degree sign...

Changed in psensor:
status: New → Confirmed
Revision history for this message
Jean-Philippe Orsini (jfi) wrote :

Already fixed upstream few months ago in the development branch (will be in the future 0.7.0 release).

You can give it a try using ppa:jfi/psensor-unstable.

Thanks for the report.

Changed in psensor (Ubuntu):
status: New → Confirmed
Revision history for this message
Jean-Philippe Orsini (jfi) wrote :
Revision history for this message
Jean-Philippe Orsini (jfi) wrote :

Fix commited upstream in the 0.6.2.x branch.

Attached the debdiff for Ubuntu Precise.

Subscribed ubuntu-sponsor team for uploading it.
Ubuntu Quantal has 0.6.2.16-1ubuntu5 instead of 0.6.2.16-1ubuntu4 but that's just for a rebuild [1]. Sould I also provide a debdiff for Quantal?

[1] http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/quantal/psensor/quantal/revision/12

Revision history for this message
Bence Lukács (lukacs-bence1) wrote :

Thanks a lot for the patch! I hope I can see the fix in the near future also for precise and quantal. :-)

Revision history for this message
Bence Lukács (lukacs-bence1) wrote :

And I don't think it is neccesary to provide the debdiff for Quantal...

tags: added: quantal
tags: added: precise
Revision history for this message
Micah Gersten (micahg) wrote :

Taking a look

Changed in psensor (Ubuntu):
assignee: nobody → Micah Gersten (micahg)
status: Confirmed → In Progress
Revision history for this message
Micah Gersten (micahg) wrote :

A few things. First, you don't need Closes when closing LP bugs, second, the precise version should've been 0.6.2.16-1ubuntu4.1 and targeted precise-proposed. Also, we'll need a test case and a regression potential for precise before this can be accepted into precise-proposed. In the mean time, I've uploaded the SRU as the SRU team has been running a little behind due to the large number of SRUs. Please complete step 2 as noted here: https://wiki.ubuntu.com/StableReleaseUpdates#Procedure

Changed in psensor (Ubuntu):
assignee: Micah Gersten (micahg) → nobody
Changed in psensor (Ubuntu Precise):
importance: Undecided → Low
Changed in psensor (Ubuntu):
importance: Undecided → Low
Changed in psensor (Ubuntu Precise):
status: New → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package psensor - 0.6.2.16-1ubuntu6

---------------
psensor (0.6.2.16-1ubuntu6) quantal; urgency=low

  * debian/patches/LP1021900.patch
    - added degree Celcius symbol. (LP: #1021900)
 -- Jean-Philippe Orsini <email address hidden> Sat, 07 Jul 2012 00:47:44 +0200

Changed in psensor (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Jean-Philippe Orsini (jfi) wrote :

Screenshot of psensor with the bug

Revision history for this message
Jean-Philippe Orsini (jfi) wrote :

Psensor with the fix

Revision history for this message
Jean-Philippe Orsini (jfi) wrote :

Thanks Micah for the Quantal upload.

This bug is not critical, it does not block the usage of Psensor.
The fix is trivial, has low risk of regression but it adresses a cosmetic issue.

See https://bugs.launchpad.net/psensor/+bug/1021900/+attachment/3225364/+files/LP1021900_KO.png and https://bugs.launchpad.net/psensor/+bug/1021900/+attachment/3225366/+files/LP1021900_OK.png for better understanding.

I don't think that this bug is important enough to spend times of a SRU member on it. I am quite sure that they have plenty more important fixes to check than this bug.

If somebody disagrees with my opinion, please let me know, I will provide all SRU information and a correct patch (taking care of the previous comments from Micah).

Revision history for this message
Jean-Philippe Orsini (jfi) wrote :

screenshot with the correct celcius display with precise-proposed patch

Revision history for this message
Jean-Philippe Orsini (jfi) wrote :

New version of the patch:
 - target precise-proposed
 - fixed the ref to the LP bugs in the changelog

description: updated
description: updated
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Bence, or anyone else affected,

Accepted psensor into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/psensor/0.6.2.16-1ubuntu4.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in psensor (Ubuntu Precise):
status: Triaged → Fix Committed
tags: added: verification-needed
Revision history for this message
Steve Langasek (vorlon) wrote :

Lukács, can you confirm whether the psensor package in precise-proposed fixes this issue for you?

Revision history for this message
Bence Lukács (lukacs-bence1) wrote :

Steve, yes the package in the proposed repo (0.6.2.16-1ubuntu4.1) fixes the problem.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Colin Watson (cjwatson) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package psensor - 0.6.2.16-1ubuntu4.1

---------------
psensor (0.6.2.16-1ubuntu4.1) precise-proposed; urgency=low

  * debian/patches/LP1021900.patch
    - added degree Celcius symbol. (LP: #1021900)
 -- Jean-Philippe Orsini <email address hidden> Sat, 07 Jul 2012 00:47:44 +0200

Changed in psensor (Ubuntu Precise):
status: Fix Committed → Fix Released
Changed in psensor:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.