lxc-clone shouldn't be messing with dhclient.conf, causes conffile upgrade prompts on quantal
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| lxc (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
| Precise |
Fix Released
|
Medium
|
Stéphane Graber | ||
| Quantal |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
lxc-clone currently updates the host-name option of /etc/dhcp/
This isn't needed as Ubuntu uses "<hostname>" or "gethostname()" as dynamic placeholders specifically to avoid updating that file.
In quantal, I replaced our "<hostname>" patch by the isc upstream "gethostname()" call in dhclient.conf, the upgrade worked fine for any regular system but would cause a conffile upgrade prompt on containers that were copied using lxc-clone.
I updated lxc-clone to only update host-name on systems that don't have "<hostname>" or "gethostname()" so we don't regress the behaviour for other distros but fix Debian and Ubuntu.
[rational]
There's no reason to currently updated /etc/dhcp/
[test case]
1) lxc-create -t ubuntu -n p1
2) lxc-clone -o p1 -n p2
3) grep host-name /var/lib/
3) shouldn't contain the container's hostname but "<hostname>" or "gethostname()" (depending on Ubuntu versions of isc-dhcp)
[regression potential]
I believe the grep call is correct but should it fail, the worst that can happen is some system not getting their /etc/dhcp/
Related branches
| Changed in lxc (Ubuntu Quantal): | |
| status: | New → Fix Released |
| Changed in lxc (Ubuntu Precise): | |
| importance: | Undecided → Medium |
| assignee: | nobody → Stéphane Graber (stgraber) |
| status: | New → In Progress |
| Brian Murray (brian-murray) wrote Please test proposed package | #1 |
| Changed in lxc (Ubuntu Precise): | |
| status: | In Progress → Fix Committed |
| tags: | added: verification-needed |
| Stéphane Graber (stgraber) wrote | #2 |
| tags: |
added: verification-done removed: verification-needed |
| Launchpad Janitor (janitor) wrote | #3 |
| Changed in lxc (Ubuntu Precise): | |
| status: | Fix Committed → Fix Released |
Hello Stéphane, or anyone else affected,
Accepted lxc into precise-proposed. The package will build now and be available at http://
Please help us by testing this new package. See https:/
If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-
Further information regarding the verification process can be found at https:/