fwts: method test reports mutex lock failures in a seemingly non-deterministic way with some firmware

Bug #1017388 reported by Colin Ian King
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
fwts (Ubuntu)
Fix Released
Medium
Colin Ian King
Precise
Fix Released
Undecided
Unassigned

Bug Description

We sometimes see failures like the following:

method FAILED [MEDIUM] AMLLocksAcquired: Test 61, \_WAK left 1
method locks in an acquired state.
method
method ADVICE: Locks left in an acquired state generally
method indicates that the AML code is not releasing a lock. This
method can sometimes occur when a method hits an error condition#
method and exits prematurely without releasing an acquired lock.
method It may be occurring in the method being tested or other
method methods used while evaluating the method.

..but for some reason it seems to happen non-deterministically. Probably a race somewhere. Needs fixing.

Changed in fwts (Ubuntu):
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Colin King (colin-king)
summary: - fwts: method test repoorts mutex lock failures in a seemingly non-
+ fwts: method test reports mutex lock failures in a seemingly non-
deterministic way with some firmware
Revision history for this message
Colin Ian King (colin-king) wrote :

Bug occurs because of non-serialized control methods incrementing and decrementing the semaphore counts and not being protected by a mutex. Patch sent to the mailing list.

Revision history for this message
Colin Ian King (colin-king) wrote :

..and also because Notify() calls are being spawned off and we're not waiting for these pthreads to complete before we do the lock accounting. Patches to address this are pending on the mailing list too.

Revision history for this message
Colin Ian King (colin-king) wrote :
Changed in fwts (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Colin Ian King (colin-king) wrote :

Will be released next week in version V0.25.06

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package fwts - 0.25.06

---------------
fwts (0.25.06) quantal; urgency=low

  [Alex Hung]
  * acpi: method: Change _BBN's test_type from METHOD_MOBILE to METHOD_OPTIONAL

  [Colin Ian King]
  * acpi: acpidump: add extra ACPI 5.0 fields to FACP
  * acpi: acpidump: Add support for bit 20 and 21 of FADT flags
  * Update FADT preferred PM profile to add Tablet
  * dmi: dmi_decode: make advice more relevant to data handled by the kernel
  * Add mutex around semaphore counting (LP: #1017388)
  * acpi: method: remove race delay kludge
  * lib: acpi_acpi_tables: Add tables based on ACPI name and not file name.
  * lib: fwts_acpi_tables: Force fixup on XSDT and RSDT when loading from .dat
    files
  * lib: acpica: fix semaphore counting by waiting for threads to complete
  * acpica: incorporate new ACPICA sources to enable fwts to build
  * acpica: use latest ACPICA source
  * Update copy-acpica.sh to copy over new sources
  * Update README_ACPICA.txt to add in new acpica sources
  * acpi: acpidump + acpi headers: Add simple support for FPDT
  * acpi: acpidump + acpi headers: Add basic dump of RASF
  * acpi: acpidump: Add stub for MPST
  * acpi: acpidump: make arrays static
  * data: klog.json: make the _OSC failure advice more general and hand-wavy
  * cpu: cpufreq: cpufreq and cpuidle dirs confusing cpuN parsing
  * cpu: cpufreq: make progress estimate more accurate
  * cpu: cpufreq: tidy up table output
  * cpu: cpufreq: rename some global variables to make them more readable
  * cpu: cpufreq: various whitespace clean ups
  * cpu: cpufreq: tidy up memset usage
  * cpu: cpufreq: make HzToHuman() more efficient
  * cpu: cpufreq: add need to run as root
  * bios: mtrr: fix stupid typos
  * lib: fwts_klog: optimize regex scanning (LP: #1028031)

  [Keng-Yu Lin]
  * debian: Add hardening options
 -- Keng-Yu Lin <email address hidden> Fri, 27 Jul 2012 17:22:07 +0800

Changed in fwts (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Chris Halse Rogers (raof) wrote : Please test proposed package

Hello Colin, or anyone else affected,

Accepted fwts into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/fwts/0.25.06precise1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in fwts (Ubuntu Precise):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Keng-Yu Lin (lexical) wrote :

With the fwts in precise-proposed, this bug is fixed.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Colin Watson (cjwatson) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package fwts - 0.25.06precise1

---------------
fwts (0.25.06precise1) precise-proposed; urgency=low

  * Stable Release Update for Precise (LP: #1033451)

  [Alex Hung]
  * acpi: method: Change _BBN's test_type from METHOD_MOBILE to METHOD_OPTIONAL

  [Colin Ian King]
  * acpi: acpidump: add extra ACPI 5.0 fields to FACP
  * acpi: acpidump: Add support for bit 20 and 21 of FADT flags
  * Update FADT preferred PM profile to add Tablet
  * dmi: dmi_decode: make advice more relevant to data handled by the kernel
  * Add mutex around semaphore counting (LP: #1017388)
  * acpi: method: remove race delay kludge
  * lib: acpi_acpi_tables: Add tables based on ACPI name and not file name.
  * lib: fwts_acpi_tables: Force fixup on XSDT and RSDT when loading from .dat
    files
  * lib: acpica: fix semaphore counting by waiting for threads to complete
  * acpica: incorporate new ACPICA sources to enable fwts to build
  * acpica: use latest ACPICA source
  * Update copy-acpica.sh to copy over new sources
  * Update README_ACPICA.txt to add in new acpica sources
  * acpi: acpidump + acpi headers: Add simple support for FPDT
  * acpi: acpidump + acpi headers: Add basic dump of RASF
  * acpi: acpidump: Add stub for MPST
  * acpi: acpidump: make arrays static
  * data: klog.json: make the _OSC failure advice more general and hand-wavy
  * cpu: cpufreq: cpufreq and cpuidle dirs confusing cpuN parsing
  * cpu: cpufreq: make progress estimate more accurate
  * cpu: cpufreq: tidy up table output
  * cpu: cpufreq: rename some global variables to make them more readable
  * cpu: cpufreq: various whitespace clean ups
  * cpu: cpufreq: tidy up memset usage
  * cpu: cpufreq: make HzToHuman() more efficient
  * cpu: cpufreq: add need to run as root
  * bios: mtrr: fix stupid typos
  * lib: fwts_klog: optimize regex scanning (LP: #1028031)

  [Keng-Yu Lin]
  * debian: Add hardening options
 -- Keng-Yu Lin <email address hidden> Fri, 27 Jul 2012 17:22:07 +0800

Changed in fwts (Ubuntu Precise):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.