linuxbridge_quantum_agent device_exists() is buggy

Bug #1015953 reported by yong sheng gong
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Juliano Martinez

Bug Description

Code: def device_exists(self, device):
        """Check if ethernet device exists."""
        retval = utils.execute(['ip', 'link', 'show',
                                'dev', device], root_helper=self.root_helper)
        if retval:
            return True
        else:
            return False

is buggy because utils.execute() will raise RuntimeError() if the dev is not there.

Juliano Martinez (ncode)
Changed in quantum:
assignee: nobody → Juliano Martinez (juliano-martinez)
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/8797

Changed in quantum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/8797
Committed: http://github.com/openstack/quantum/commit/79d0bd7124be60075e59b4662c7b7315b78c4f4e
Submitter: Jenkins
Branch: master

commit 79d0bd7124be60075e59b4662c7b7315b78c4f4e
Author: ncode <email address hidden>
Date: Thu Jun 21 07:27:52 2012 -0300

    Bug 1015953 - linuxbridge_quantum_agent device_exists() is buggy

    Just added the check_exit_code=False to utils.execute call

    Change-Id: I3105131e853d45609bc441482bf5b3c3e035a129

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
milestone: none → folsom-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: folsom-2 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.