webkit report: unhelpful diagnosis message when wkhtmltopdf exists with error status
Bug #1003819 reported by
Alexandre Fayolle - camptocamp
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Odoo Addons (MOVED TO GITHUB) |
Fix Committed
|
Undecided
|
Alexandre Fayolle - camptocamp | ||
Bug Description
Alexis Delattre reported an issue on c2c-financial-
There is another issue that I tackled on the c2c module which is that the code was using subprocess.call with stderr=PIPE which is something that must never be done as it can lead to a deadlock in the application (see http://
Related branches
lp:~stan/openobject-addons/lp1003819b
- Alexandre Fayolle - camptocamp (community): Disapprove
- OpenERP Core Team: Pending requested
-
Diff: 16 lines (+5/-1)1 file modifiedreport_webkit/webkit_report.py (+5/-1)
lp:~camptocamp/openobject-addons/trunk-fix1003819
- Nicolas Bessi - Camptocamp (community): Approve (code review only)
- Guewen Baconnier @ Camptocamp (community): Approve
- OpenERP Core Team: Pending requested
-
Diff: 60 lines (+26/-15)1 file modifiedreport_webkit/webkit_report.py (+26/-15)
lp:~camptocamp/openobject-addons/6.0-fix1003819
- Nicolas Bessi - Camptocamp (community): Approve (code review)
- OpenERP Core Team: Pending requested
-
Diff: 49 lines (+25/-14)1 file modifiedreport_webkit/webkit_report.py (+25/-14)
lp:~camptocamp/openobject-addons/7.0-fix1003819
- Nicolas Bessi - Camptocamp: Pending requested
- OpenERP Core Team: Pending requested
-
Diff: 60 lines (+26/-15)1 file modifiedreport_webkit/webkit_report.py (+26/-15)
| Changed in openobject-addons: | |
| assignee: | nobody → Nicolas Bessi - Camptocamp (nbessi-c2c) |
| Changed in openobject-addons: | |
| status: | New → Confirmed |
| Changed in openobject-addons: | |
| assignee: | Nicolas Bessi - Camptocamp (nbessi-c2c) → Alexandre Fayolle @ camptocamp (alexandre-fayolle-c2c) |
| Changed in openobject-addons: | |
| status: | Confirmed → In Progress |
Revision history for this message
| Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote | #1 |
Revision history for this message
| Amit Parik (amit-parik) wrote | #2 |
Revision history for this message
| Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote | #3 |
| Changed in openobject-addons: | |
| status: | In Progress → Fix Committed |
To post a comment you must log in.
Hello Ravish,
I have the merge requests approved by Nicolas. How do we proceed to get this merged in 6.0, 6.1 and trunk?