Merge lp:~stan/openobject-addons/lp1003819b into lp:openobject-addons

Proposed by Tristan Hill on 2012-07-04
Status: Rejected
Rejected by: Fabien (Open ERP) on 2012-09-30
Proposed branch: lp:~stan/openobject-addons/lp1003819b
Merge into: lp:openobject-addons
Diff against target: 16 lines (+5/-1)
1 file modified
report_webkit/webkit_report.py (+5/-1)
To merge this branch: bzr merge lp:~stan/openobject-addons/lp1003819b
Reviewer Review Type Date Requested Status
Alexandre Fayolle - camptocamp (community) Disapprove on 2012-07-24
OpenERP Core Team 2012-07-04 Pending
Review via email: mp+113354@code.launchpad.net

Description of the change

[IMP] log stderr output

To post a comment you must log in.

does not solve the whole problem: the user has no feedback about what went wrong.

review: Disapprove
Fabien (Open ERP) (fp-tinyerp) wrote :

I agree with Alexandre.

Unmerged revisions

6975. By Tristan Hill on 2012-07-04

[IMP] log stderr output

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'report_webkit/webkit_report.py'
2--- report_webkit/webkit_report.py 2012-06-22 06:48:54 +0000
3+++ report_webkit/webkit_report.py 2012-07-04 09:11:22 +0000
4@@ -161,7 +161,11 @@
5 command.append(html_file.name)
6 command.append(out_filename)
7 try:
8- status = subprocess.call(command, stderr=subprocess.PIPE) # ignore stderr
9+ p = subprocess.Popen(command, stderr=subprocess.PIPE)
10+ for line in p.stderr:
11+ logger.error(line)
12+ status = p.wait()
13+ p.stderr.close()
14 if status :
15 raise except_osv(
16 _('Webkit raise an error' ),

Subscribers

People subscribed via source and target branches

to all changes: