Quickly

quickly package --extras doesn't generate a usable desktop file

Bug #1002417 reported by Andrew Starr-Bochicchio
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Quickly
Fix Released
Undecided
Unassigned
Quickly 12.05
quickly (Ubuntu)
Fix Released
Undecided
Unassigned
Precise
Fix Released
Undecided
Unassigned

Bug Description

[Impact]

The commands 'quickly package --extras' and 'quickly submitubuntu' do not create debian packages that can launch the program from the menus.

So those two commands, which are used for ARB submission, will appear completely broken (and are due to other bugs). Since we want to encourage ARB submission where appropriate, having such bugs would be unfortunate.

[Test Case]

cd /tmp
quickly create ubuntu-application ubuapp
# close opened window
cd ubuapp
quickly package --extras
sudo dpkg -i ../ubuapp_0.1_all.deb
# Search for ubuapp in the menu and try to launch it

[Regression Potential]

My fix carefully only affects the --extras path (which is also used for submitubuntu). I intentionally chose an ugly way to fix this so that I could only affect that path and not regress anything else.

In 12.10, my hope is to eventually implement a non-ugly fix. But I'm confident this will only affect users of --extras.

[Original Report]

1) the desktop file is installed to /opt/extras.ubuntu.com/qreator/share/applications/ The system won't pick it up there.

2) The Exec and Icon lines in the desktop file don't point to the actually installed files in opt:

Exec=qreator
Icon=/usr/share/qreator/media/qreator.svg

Even if you edit the icon path to be correct for opt, setup.py stomps on it since "datadir" isn't set correctly (see bug 998910) and this is called:

        for line in fin:
            if 'Icon=' in line:
                line = "Icon=%s\n" % (datadir + 'media/qreator.svg')
            fout.write(line)

See original description

Related branches

lp:~andrewsomething/quickly/1002417
lp:~mterry/quickly/extras
Didier Roche-Tolomelli: Approve
Diff: 357 lines (+186/-132)
4 files modified
data/templates/ubuntu-application/internal/packaging.py (+86/-55)
data/templates/ubuntu-application/test/extras.sh (+99/-0)
data/templates/ubuntu-application/test/metadata.sh (+0/-76)
data/templates/ubuntu-application/test/package.sh (+1/-1)
lp:ubuntu/quantal/quickly
lp:ubuntu/precise-proposed/quickly
Andrew Starr-Bochicchio (andrewsomething)
Changed in quickly:
status: New → In Progress
assignee: nobody → Andrew Starr-Bochicchio (andrewsomething)
Revision history for this message
Michael Terry (mterry) wrote :

Whoops. I had started on a branch to fix the extras code before I saw this bug. :-/ I'll link my branch too.

Michael Terry (mterry)
Changed in quickly:
assignee: Andrew Starr-Bochicchio (andrewsomething) → nobody
status: In Progress → Fix Committed
Michael Terry (mterry)
Changed in quickly:
milestone: none → 12.05
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package quickly - 12.05-0ubuntu1

---------------
quickly (12.05-0ubuntu1) quantal; urgency=low

  * New upstream release
    - Fix ubuntu-flash-game backend to work (LP: #1007086)
    - For ubuntu-cli and ubuntu-flash-game, don't keep warning about
      upgrading the project to use PyGI, even on fresh projects
      (LP: #1007006)
    - Fix 'package --extras' and 'submitubuntu' to create packages suitable
      for the ARB process again (LP: #1003818, LP: #998910, LP: #1002417)
 -- Michael Terry <email address hidden> Thu, 31 May 2012 15:25:44 -0400

Changed in quickly (Ubuntu):
status: New → Fix Released
Michael Terry (mterry)
Changed in quickly:
status: Fix Committed → Fix Released
Michael Terry (mterry)
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Andrew, or anyone else affected,

Accepted quickly into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in quickly (Ubuntu Precise):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

I've installed the packages from proposed, and I can confirm that the test case is successful. The package correctly installs the binary to /opt/extras.ubuntu.com/ubuapp/bin/ubuapp, and it runs without crashing. The desktop file now points to the correct binary and icon. It can be found and run from the Dash.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package quickly - 12.04-0ubuntu2

---------------
quickly (12.04-0ubuntu2) precise-proposed; urgency=low

  * debian/patches/fix-extras.patch:
    - Fix 'package --extras' and 'submitubuntu' to create packages suitable
      for the ARB process again (LP: #1003818, LP: #998910, LP: #1002417)
  * debian/patches/no-warn-on-fresh-cli.patch:
    - For ubuntu-cli and ubuntu-flash-game, don't keep warning about
      upgrading the project to use PyGI, even on fresh projects
      (LP: #1007006)
  * debian/patches/fix-flash-template.patch:
    - Fix flash game template to still use gtk2, as flash requires that
      (LP: #1007086)
  * debian/control:
    - Depend on webkit-1.0 and gtk-2.0 for above flash change
 -- Michael Terry <email address hidden> Thu, 31 May 2012 16:35:33 -0400

Changed in quickly (Ubuntu Precise):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.