Uncaught TypeError on translations series +imports

Bug #1000282 reported by Curtis Hovey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Richard Harding

Bug Description

line 327 Y.lp.translations.importqueue is null or not an object.
Y.lp exists, but translations is missing was not loaded or added. I see that app, bugs, and code were added, but not others. Oh, I see that all the lp modules that were added also happen to be in the base-layout-load-scripts LPJS.use().

This call in the template does not trigger the load of lp.translations.importqueue
          LPJS.use('lp.translations.importqueue', 'event', function(Y) {
              Y.on('domready', function(e) {
                  Y.lp.translations.importqueue.initialize_import_queue_page(Y);
              });
          });

Ah, and I see lp.ajax was not loaded to the AJAX Log is also broken. This looks like a combo-loader issue

Related branches

Revision history for this message
Curtis Hovey (sinzui) wrote :

This is a combo loader issue. The page loads correctly in dev when the combo-loader is disabled. The page should show the import status as an green link with an overlay instead of a select box.

Revision history for this message
Richard Harding (rharding) wrote :

Correct, the combo loader knows what modules are located where via the meta.js file in build/lib/lp. This file is generated as part of the build step. It parses each lp js module to know what it's deps are, what it provides, etc.

The translations.importqueue file isn't in the meta.js file so the combo loader fails to pull it down as requested.

Curtis Hovey (sinzui)
Changed in launchpad:
assignee: nobody → Richard Harding (rharding)
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.